Useless function? #402

Closed
ProLoser opened this Issue Sep 4, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@ProLoser
Member

ProLoser commented Sep 4, 2015

What does this even do?
https://github.com/luisfarzati/angulartics/blob/master/src/angulartics.js#L227-L230

It returns the same result in either situation

@luisfarzati

This comment has been minimized.

Show comment
Hide comment
@luisfarzati

luisfarzati Sep 7, 2015

Member

Hmm that seems pretty stupid. Maybe I was thinking in other inferences (besides isCommand) but then I forgot. What's certain is that this code never had a code review by anyone, you seem the first one to spot some fringe stuff in it. Thanks for caring!

Member

luisfarzati commented Sep 7, 2015

Hmm that seems pretty stupid. Maybe I was thinking in other inferences (besides isCommand) but then I forgot. What's certain is that this code never had a code review by anyone, you seem the first one to spot some fringe stuff in it. Thanks for caring!

@lunks

This comment has been minimized.

Show comment
Hide comment
@lunks

lunks Sep 9, 2015

Member

Feel free to do this proposals over PRs if you feel like to, @ProLoser.
It seems we can just replace https://github.com/luisfarzati/angulartics/blob/master/src/angulartics.js#L254 with

var eventType = $attrs.analyticsOn || 'click'
Member

lunks commented Sep 9, 2015

Feel free to do this proposals over PRs if you feel like to, @ProLoser.
It seems we can just replace https://github.com/luisfarzati/angulartics/blob/master/src/angulartics.js#L254 with

var eventType = $attrs.analyticsOn || 'click'

@timelf123 timelf123 closed this in b6c7a0d Dec 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment