Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless function? #402

Closed
ProLoser opened this issue Sep 4, 2015 · 2 comments
Closed

Useless function? #402

ProLoser opened this issue Sep 4, 2015 · 2 comments

Comments

@ProLoser
Copy link
Member

@ProLoser ProLoser commented Sep 4, 2015

What does this even do?
https://github.com/luisfarzati/angulartics/blob/master/src/angulartics.js#L227-L230

It returns the same result in either situation

@luisfarzati
Copy link
Member

@luisfarzati luisfarzati commented Sep 7, 2015

Hmm that seems pretty stupid. Maybe I was thinking in other inferences (besides isCommand) but then I forgot. What's certain is that this code never had a code review by anyone, you seem the first one to spot some fringe stuff in it. Thanks for caring!

@lunks
Copy link
Member

@lunks lunks commented Sep 9, 2015

Feel free to do this proposals over PRs if you feel like to, @ProLoser.
It seems we can just replace https://github.com/luisfarzati/angulartics/blob/master/src/angulartics.js#L254 with

var eventType = $attrs.analyticsOn || 'click'
@timelf123 timelf123 closed this in b6c7a0d Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.