Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
[Youtube] Remove cipher algorithm and mentions of copyrighted material
- Loading branch information
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least there is a cloneable repo indeed, but this is a loss.
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wish to reintroduce this functionality, then revert the change in your personal repo. Unfortunately as per the DMCA this code cannot be hosted on github without attracting legal issues. It's not an optimal solution but it's better than not having it online at all.
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decision reversed!
https://github.blog/2020-11-16-standing-up-for-developers-youtube-dl-is-back/
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LETS FUCKING GOOOOOOOOOOOO!
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why I don't write tests.
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change affect downloading videos (e.g. vlogs, music tutorials, reviews, and even piano recitals; see https://youtu.be/CEQQ6zkuc2U) which are heavily claimed by Content ID?
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reinhart1010 I'll be reverting this commit in favor of one similar to what's in the base fork, so the rolling cipher is restored.
Truthfully I don't know the impact of removing the rolling cipher, as this fork was primarily made to fix sites like NicoNicoDouga that the maintainers of the main ytdl-org fork refuse to accept any sort of pull request for, for a reason they always fail to mention (and lock issues/PR threads over).
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reinhart1010
If you're interested in finding out which videos have a signature attached, i'm pretty sure all you have to do is enable
--verboseand check for asignature lengthline being printed. It'll show for encrypted signatures, however for unencrypted signatures you might have to add some extra logging around here.@M-i-k-o-t-o
Thanks, I have actually talked about getting some of the NND changes ported over to youtube-dlc in the old youtube-dlc fork that's still currently down due to DMCA (not the newer yt-dlc one). The bare minimum to get the site working again has already been proposed again in blackjack4494/yt-dlc#86.
I'd be interested in porting the other features i've added over too, however some may not work due to technical constraints (such as the NND livestream extractor requiring websockets, which in turn requires at least python 3.7)
I remember discussing this with blackjack4494 but I don't remember what his response was
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that they were forced to change their code to prevent the download of certain videos shows that this isn't a win at all. The DMCA needs to be abolished completely.
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original repository has this part of the code that was removed here. It was not necessary to remove it
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in 09e24fd
@Demicro Please read the history of this thread. This change was made before GitHub / the EFF decided this was okay to keep in the code
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would hardly make any difference. Just another mafia organization would take its place.
0851123There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I actually misread it for RIAA...