From 2dfa30d0ca6fb6991640a18e53401d82f567f8ff Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Mon, 19 Feb 2024 21:51:54 -0800 Subject: [PATCH] Revert "[python] Bump Python minimum version to 3.8 (#78828)" This reverts commit 0a6c74e21cc6750c843310ab35b47763cddaaf32. This created a lot of post-commit failures due to buildbots running older versions of Python. --- llvm/CMakeLists.txt | 4 ++-- llvm/docs/GettingStarted.rst | 5 ++--- llvm/docs/GettingStartedVS.rst | 2 +- llvm/docs/ReleaseNotes.rst | 5 ----- llvm/docs/TestingGuide.rst | 2 +- 5 files changed, 6 insertions(+), 12 deletions(-) diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt index 6612f1364facd..98cef005f07e0 100644 --- a/llvm/CMakeLists.txt +++ b/llvm/CMakeLists.txt @@ -877,8 +877,8 @@ set(LLVM_PROFDATA_FILE "" CACHE FILEPATH "Profiling data file to use when compiling in order to improve runtime performance.") if(LLVM_INCLUDE_TESTS) - # All LLVM Python files should be compatible down to this minimum version. - set(LLVM_MINIMUM_PYTHON_VERSION 3.8) + # Lit test suite requires at least python 3.6 + set(LLVM_MINIMUM_PYTHON_VERSION 3.6) else() # FIXME: it is unknown if this is the actual minimum bound set(LLVM_MINIMUM_PYTHON_VERSION 3.0) diff --git a/llvm/docs/GettingStarted.rst b/llvm/docs/GettingStarted.rst index a38fd2ae45f4d..687d1f29b5a1f 100644 --- a/llvm/docs/GettingStarted.rst +++ b/llvm/docs/GettingStarted.rst @@ -288,7 +288,7 @@ uses the package and provides other details. Package Version Notes =========================================================== ============ ========================================== `CMake `__ >=3.20.0 Makefile/workspace generator -`python `_ >=3.8 Automated test suite\ :sup:`1` +`python `_ >=3.6 Automated test suite\ :sup:`1` `zlib `_ >=1.2.3.4 Compression library\ :sup:`2` `GNU Make `_ 3.79, 3.79.1 Makefile/build processor\ :sup:`3` =========================================================== ============ ========================================== @@ -296,8 +296,7 @@ Package Version Notes .. note:: #. Only needed if you want to run the automated test suite in the - ``llvm/test`` directory, or if you plan to utilize any Python libraries, - utilities, or bindings. + ``llvm/test`` directory. #. Optional, adds compression / uncompression capabilities to selected LLVM tools. #. Optional, you can use any other build tool supported by CMake. diff --git a/llvm/docs/GettingStartedVS.rst b/llvm/docs/GettingStartedVS.rst index 4b15272635fbe..a1eb88dccc9e5 100644 --- a/llvm/docs/GettingStartedVS.rst +++ b/llvm/docs/GettingStartedVS.rst @@ -55,7 +55,7 @@ Visual Studio 2019 so separate installation is not required. If you do install CMake separately, Visual Studio 2022 will require CMake Version 3.21 or later. If you would like to run the LLVM tests you will need `Python -`_. Version 3.8 and newer are known to work. You can +`_. Version 3.6 and newer are known to work. You can install Python with Visual Studio 2019, from the Microsoft store or from the `Python web site `_. We recommend the latter since it allows you to adjust installation options. diff --git a/llvm/docs/ReleaseNotes.rst b/llvm/docs/ReleaseNotes.rst index 1125ed3b3cedb..5be00d9d5a589 100644 --- a/llvm/docs/ReleaseNotes.rst +++ b/llvm/docs/ReleaseNotes.rst @@ -47,11 +47,6 @@ Non-comprehensive list of changes in this release Update on required toolchains to build LLVM ------------------------------------------- -* The minimum Python version has been raised from 3.6 to 3.8 across all of LLVM. - This enables the use of many new Python features, aligning more closely with - modern Python best practices, and improves CI maintainability - See `#78828 `_ for more info. - Changes to the LLVM IR ---------------------- diff --git a/llvm/docs/TestingGuide.rst b/llvm/docs/TestingGuide.rst index 3e3a722f14187..e32e4d1e535ab 100644 --- a/llvm/docs/TestingGuide.rst +++ b/llvm/docs/TestingGuide.rst @@ -23,7 +23,7 @@ Requirements ============ In order to use the LLVM testing infrastructure, you will need all of the -software required to build LLVM, as well as `Python `_ 3.8 or +software required to build LLVM, as well as `Python `_ 3.6 or later. LLVM Testing Infrastructure Organization