feat(ui): size slider for the List Display Mode (Closes #1894)#1906
Merged
Conversation
MavikBow
changed the title
MavikBow
changed the title
4 tasks
jmir1
previously approved these changes
Jan 31, 2025
cuong-tran
pushed a commit
to komikku-app/anikku
that referenced
this pull request
Mar 20, 2025
) (cherry picked from commit 2b1dbc1)
cuong-tran
pushed a commit
to komikku-app/anikku
that referenced
this pull request
May 31, 2025
) (cherry picked from commit 2b1dbc1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a size slider for the List Display Mode. It uses the same size variable as Grids do to determine size. However, the size of the List gets interpreted not as <number> of columns per row, but rather as <number> of entries of the list visible on the screen at once (images 1 and 2). The default value is set to be 7 for the List.
The style of the List was changed: the cover is of Book resolution to match the Grids and for better visibility (image 4).
Other two lists (browse list and migration list) don't have editable size, but neither do browse grids, so it's fine. Instead they now have a predetermined size of 76.dp (was 56.dp previously) and are visually changed to match the library list style.
The size slider also has two additional text fields added, which would need translation (though i assume that's automated).
The max line restriction for titles was removed, allowing for longer names to be fully visible, given the List is set to a big enough size (image 6).
closes #1894
Showcase