fixup(ui): make the default list a set size and make browse list scale - #1914
Merged
Merged
Conversation
MavikBow
force-pushed
the
list-size-slider
branch
from
January 31, 2025 17:51
658aec4 to
214b0e4
Compare
Member
|
I also noticed the list size setting doesn't apply when browsing sources. In contrast, the grid size is the same as in the library view |
Contributor
Author
|
You're absolutely right. For some reason I thought that browse grids just stick to the default size. I'll start on fixing that. |
Contributor
Author
Member
|
I am not sure if this'd work but have you tried using Intrinsic measurements? |
Contributor
Author
Collaborator
It's the linter complaining about the code style, you can (probably) fix it with |
MavikBow
force-pushed
the
list-size-slider
branch
from
February 1, 2025 16:32
bfca4ab to
69d7987
Compare
Contributor
Author
|
Yeah, I think this is done. When (and if) this gets merged, I'll reopen the identical PR in mihon with these fixes as well. |
jmir1
approved these changes
Mar 22, 2025
cuong-tran
pushed a commit
to komikku-app/anikku
that referenced
this pull request
Mar 23, 2025
…niyomiorg/aniyomi#1914) (cherry picked from commit 6067113)
cuong-tran
pushed a commit
to komikku-app/anikku
that referenced
this pull request
May 31, 2025
…niyomiorg/aniyomi#1914) (cherry picked from commit 6067113)
nubesurrealista
pushed a commit
to nubesurrealista/Kumo
that referenced
this pull request
Jul 18, 2025
…niyomiorg/aniyomi#1914) (cherry picked from commit 606711357863e12e9dce5f7e16ca702fa4ee7382)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




I came to the conclusion that setting number 7 as the default wouldn't be ideal. Some people might've enjoyed the original list because it would scale with their phone UI if they changed it. I now made the default to be a set value like both the migration list and browse list. It doesn't take away any options because users can just put 7 themselves on the slider. And it's faithful to the previous list.
it's a 3 line change, guys. I hope someone can find some time to merge this in.
(fixup to 2b1dbc1)
Edit: well... it's a bit more than 3 lines now, but it now fixes a glitch where the browse list didn't scale like the library list does.