Skip to content

Fix some downloader issues#1964

Merged
jmir1 merged 8 commits into
mainfrom
downloader
Mar 22, 2025
Merged

Fix some downloader issues#1964
jmir1 merged 8 commits into
mainfrom
downloader

Conversation

@Secozzi

@Secozzi Secozzi commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

Fix some downloader issues:

  • Fix videos being deleted upon completion
  • Fix Audio tracks not being added
  • Fix subtitle & audio tracks not being added for some videos
  • Fix headers not being applied to audio & subtitle tracks
  • Fix not being able to find downloaded due to file extension mismatch
  • Fix ffmpeg failing for some videos due to faulty options
  • Adds proper logging to diagnose any downloader issues

Potential TODOs:

  • Use async execution of ffmpeg
  • Don't pause/resume all downloads on reorder/cancellation, since ffmpeg doesn't support pausing/resuming

Closes #1068
Closes #1544
Closes #1547
Closes #1781
Closes #1872
Closes #1930
(May or may not fix all the issues above, but if not they can create a new issue which will now have better logs)

@jmir1

jmir1 commented Mar 22, 2025

Copy link
Copy Markdown
Member

Pausing is overrated anyways and has worked 0.1% of the time

@jmir1 jmir1 merged commit 5179dc7 into main Mar 22, 2025
@jmir1 jmir1 deleted the downloader branch March 22, 2025 17:13
cuong-tran pushed a commit to komikku-app/anikku that referenced this pull request May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment