Small fix for downloader + code cleanup - #2001
Merged
Merged
Conversation
krysanify
added a commit
to krysanify/aniyomi
that referenced
this pull request
May 24, 2025
* fix(player): use statistics callback for progress instead of logs * Remove unused code * only add http headers to http urls --------- Co-authored-by: Secozzi <folke.steen85@gmail.com>
krysanify
added a commit
to krysanify/aniyomi
that referenced
this pull request
May 29, 2025
* fix(player): use statistics callback for progress instead of logs * Remove unused code * only add http headers to http urls --------- Co-authored-by: Secozzi <folke.steen85@gmail.com>
jmir1
approved these changes
May 30, 2025
weblate
pushed a commit
to weblate/anikku
that referenced
this pull request
Aug 27, 2026
(cherry picked from commit f6ae89d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, ffmpeg doesn't want to execute the log callback which prevents the progress from being updated so we use the statistics callback instead. This won't help if ffprobe also decides to not send logs, but I haven't managed to figure out a fix for that.