This repository was archived by the owner on Nov 11, 2026. It is now read-only.
Repository navigation
fix: shared download cache - #2184
Merged
Merged
Conversation
choppeh
marked this pull request as draft
October 5, 2025 07:00
choppeh
marked this pull request as ready for review
October 5, 2025 07:03
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2136
The cache shared between anime and manga is overwritten and filtered by the extension name, so if the anime cache is written first and the cache invalidation time has not yet been reached, the manga cache will not have the same cache extension names loaded, so it will not be possible to verify downloads correctly.
SourceId is null, so mapNotNull will remove the manga extension directory, as sourceMap is from the anime extensions.
aniyomi/app/src/main/java/eu/kanade/tachiyomi/data/download/anime/AnimeDownloadCache.kt
Line 359 in 28fb936
sourceMap: Manga
aniyomi/app/src/main/java/eu/kanade/tachiyomi/data/download/manga/MangaDownloadCache.kt
Line 361 in 28fb936
Cache loading
Animes
aniyomi/app/src/main/java/eu/kanade/tachiyomi/data/download/anime/AnimeDownloadCache.kt
Line 112 in 28fb936
Mangas
aniyomi/app/src/main/java/eu/kanade/tachiyomi/data/download/manga/MangaDownloadCache.kt
Line 112 in 28fb936