New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fail on Elasticsearch 5.3.1 #907

Closed
titanmaru opened this Issue Apr 29, 2017 · 1 comment

Comments

2 participants
@titanmaru
Contributor

titanmaru commented Apr 29, 2017

As in ES version 5.3.1 release notes, they rejected any bulk index with empty IDs which cause one test to fail.

titanmaru added a commit to titanmaru/searchkick that referenced this issue Apr 29, 2017

ankane added a commit that referenced this issue Apr 29, 2017

@ankane

This comment has been minimized.

Show comment
Hide comment
@ankane

ankane Apr 29, 2017

Owner

Fixed by #908 🎉

Owner

ankane commented Apr 29, 2017

Fixed by #908 🎉

@ankane ankane closed this Apr 29, 2017

mikelkew added a commit to mikelkew/searchkick that referenced this issue May 1, 2017

Merge commit '1fb35cc0f183480e018daa8a5da6b163f22732bd' into handle_h…
…ashie

* commit '1fb35cc0f183480e018daa8a5da6b163f22732bd': (27 commits)
  Use better ActiveRecord hook - fixes ankane#910
  Removed unnecessary option [skip ci]
  Updated readme
  resolve customizable queue name as requested in ankane#799 (ankane#909)
  Updated tests to ES 5.3.2
  fix bulk index without IDs ankane#907 (ankane#908)
  Updated tests to ActiveRecord 5.1
  Version bump to 2.2.1
  Added index_suffix option - ankane#891
  Added load: {dumpable: true} option - closes ankane#887
  Test on Elasticsearch 5.3
  Updated changelog [skip ci]
  Support avg, cardinality, min, max and sum metric aggregates (ankane#877)
  Support cardinality metric aggregator (ankane#876)
  Improved exclude example [skip ci]
  Accept string for exclude option
  Improved synonyms section [skip ci]
  Added test for OR operator scoring
  Version bump to 2.2.0
  Fixed exclude case for exact match
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment