New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cardinality metric aggregator #876

Merged
merged 1 commit into from Mar 21, 2017

Conversation

2 participants
@jprosevear
Contributor

jprosevear commented Mar 21, 2017

Support cardinality metric aggregator - I suspect a next incremental step could be support for more metric aggregators by just maintaining a list of them (ie [:cardinality, :value_count...]), I think they are pretty much all the same in terms of query structure.

@ankane ankane merged commit ff4c804 into ankane:master Mar 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ankane

This comment has been minimized.

Show comment
Hide comment
@ankane

ankane Mar 21, 2017

Owner

Hey @jprosevear, thanks for the PR 💯

Agreed we should find a more general way to address different agg types. I think we should try to find a way where we don't have to change Searchkick when new types are added to ES.

Owner

ankane commented Mar 21, 2017

Hey @jprosevear, thanks for the PR 💯

Agreed we should find a more general way to address different agg types. I think we should try to find a way where we don't have to change Searchkick when new types are added to ES.

mikelkew added a commit to mikelkew/searchkick that referenced this pull request May 1, 2017

Merge commit '1fb35cc0f183480e018daa8a5da6b163f22732bd' into handle_h…
…ashie

* commit '1fb35cc0f183480e018daa8a5da6b163f22732bd': (27 commits)
  Use better ActiveRecord hook - fixes ankane#910
  Removed unnecessary option [skip ci]
  Updated readme
  resolve customizable queue name as requested in ankane#799 (ankane#909)
  Updated tests to ES 5.3.2
  fix bulk index without IDs ankane#907 (ankane#908)
  Updated tests to ActiveRecord 5.1
  Version bump to 2.2.1
  Added index_suffix option - ankane#891
  Added load: {dumpable: true} option - closes ankane#887
  Test on Elasticsearch 5.3
  Updated changelog [skip ci]
  Support avg, cardinality, min, max and sum metric aggregates (ankane#877)
  Support cardinality metric aggregator (ankane#876)
  Improved exclude example [skip ci]
  Accept string for exclude option
  Improved synonyms section [skip ci]
  Added test for OR operator scoring
  Version bump to 2.2.0
  Fixed exclude case for exact match
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment