New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match test mode when using parallel_spec #891

Closed
wants to merge 1 commit into
base: master
from

Conversation

2 participants
@razum2um

razum2um commented Apr 10, 2017

Hi, we're following these instructions to get parallel_spec + searchkick working: https://github.com/grosser/parallel_tests/wiki#with-searchkick----by-emaxi

This corrects behaviour across all running processes

@ankane

This comment has been minimized.

Show comment
Hide comment
@ankane

ankane Apr 11, 2017

Owner

Hey @razum2um, thanks for the PR 👍

Instead of changing the env, I think it'd be better to add an index_suffix option, so you could do:

Searchkick.index_suffix = ENV["TEST_ENV_NUMBER"]
Owner

ankane commented Apr 11, 2017

Hey @razum2um, thanks for the PR 👍

Instead of changing the env, I think it'd be better to add an index_suffix option, so you could do:

Searchkick.index_suffix = ENV["TEST_ENV_NUMBER"]

ankane added a commit that referenced this pull request Apr 16, 2017

@ankane

This comment has been minimized.

Show comment
Hide comment
@ankane

ankane Apr 16, 2017

Owner

Hey @razum2um, I added an index_suffix option and tested it with parallel tests. Thanks again for the PR.

Owner

ankane commented Apr 16, 2017

Hey @razum2um, I added an index_suffix option and tested it with parallel tests. Thanks again for the PR.

@ankane ankane closed this Apr 16, 2017

@razum2um

This comment has been minimized.

Show comment
Hide comment
@razum2um

razum2um Apr 17, 2017

@ankane cool, thanks for push, didn't get time to submit PR like you wished. When could you release it?

razum2um commented Apr 17, 2017

@ankane cool, thanks for push, didn't get time to submit PR like you wished. When could you release it?

@ankane

This comment has been minimized.

Show comment
Hide comment
@ankane

ankane Apr 17, 2017

Owner

A new version was published earlier today.

Owner

ankane commented Apr 17, 2017

A new version was published earlier today.

@razum2um

This comment has been minimized.

Show comment
Hide comment
@razum2um

razum2um Apr 17, 2017

Thanks a lot for the gem and such responsiveness! ❤️

razum2um commented Apr 17, 2017

Thanks a lot for the gem and such responsiveness! ❤️

mikelkew added a commit to mikelkew/searchkick that referenced this pull request May 1, 2017

Merge commit '1fb35cc0f183480e018daa8a5da6b163f22732bd' into handle_h…
…ashie

* commit '1fb35cc0f183480e018daa8a5da6b163f22732bd': (27 commits)
  Use better ActiveRecord hook - fixes #910
  Removed unnecessary option [skip ci]
  Updated readme
  resolve customizable queue name as requested in ankane/searchkick#799 (#909)
  Updated tests to ES 5.3.2
  fix bulk index without IDs ankane/searchkick#907 (#908)
  Updated tests to ActiveRecord 5.1
  Version bump to 2.2.1
  Added index_suffix option - #891
  Added load: {dumpable: true} option - closes #887
  Test on Elasticsearch 5.3
  Updated changelog [skip ci]
  Support avg, cardinality, min, max and sum metric aggregates (#877)
  Support cardinality metric aggregator (#876)
  Improved exclude example [skip ci]
  Accept string for exclude option
  Improved synonyms section [skip ci]
  Added test for OR operator scoring
  Version bump to 2.2.0
  Fixed exclude case for exact match
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment