Update inline playback button to material design (#4104) #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I'll merge this now and see what people think of it. |
hssm
added a commit
that referenced
this pull request
Mar 1, 2016
Update inline playback button to material design (#4104)
|
@glutanimate, thank you for the work. |
|
Thanks for merging, @hssm. I am glad you guys like it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses my feature request in #4104.
It replaces the old gingerbread-styled inline playback icon with a more modern design. The new icon is based on ic_play_arrow_48px.svg which is part of the official material design iconset (license:CC-BY 4.0) .
To account for darker card backgrounds I flattened the icon, as suggested by @hssm.