New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not require mac-win #28

Closed
tarsius opened this Issue Jun 14, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@tarsius
Copy link

tarsius commented Jun 14, 2017

In b610894 you added a soft dependency on mac-win. This seems unnecessary to me. Recent Emacsen do not contain that library anymore, it was removed when support for "Carbon Emacs" was removed. Also its header used to say that it is automatically loaded by startup.el when appropriate. So even if you need that library for backward compatibility, you still don't need to load it explicitly.

I stumbled into this change while automatically extracting dependency information for the Emacsmirror. The tools used to do so currently report this as an unsatisfied dependency.

@anler

This comment has been minimized.

Copy link
Owner

anler commented Jun 17, 2017

Thanks for reporting it @tarsius. What do you think @wyuenho , can we delete that requirement?

@wyuenho

This comment has been minimized.

Copy link
Contributor

wyuenho commented Jun 17, 2017

Carbon Emacs still survives sound and well. It is still being actively developed, packaged and published. Contrary to popular believe, it does not use any Carbon APIs. It merely keeps the old Carbon Emacs default behavior by porting it to Cocoa.

The only reason I (require 'mac-win nil t), was to remove the compilation warnings for mac-mwheel-scroll (I guess it's not loaded by startup.el anymore). The requirement of this is not even listed in the Package-Requires header, so I'm not sure why it will cause problems.

@wyuenho

This comment has been minimized.

Copy link
Contributor

wyuenho commented Jun 17, 2017

If I wrap eval-when-compile over the require, would that solve the Emacsmirror problem?

@tarsius

This comment has been minimized.

Copy link

tarsius commented Jun 17, 2017

Simply knowing why the feature is being loaded is enough - I can now mark it as needed for "Emacs Mac-port compatibility".

@tarsius tarsius closed this Jun 17, 2017

@anler

This comment has been minimized.

Copy link
Owner

anler commented Jun 17, 2017

Thanks both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment