Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BUILD_STATIC_BINARY env var for building a static lumo binary #475

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
2 participants
@arichiardi
Copy link
Collaborator

commented Apr 24, 2019

A nice use case for the static binary is for building an AWS Custom Runtime,
see also https://github.com/grav/aws-lumo-cljs-runtime

@arichiardi

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 24, 2019

Oh I also saw that the CircleCI conf does not produce the three binaries anymore...ooops I have been going around telling that at Clojure/North 🤭

@arichiardi arichiardi requested a review from anmonteiro Apr 24, 2019

@anmonteiro

This comment has been minimized.

Copy link
Owner

commented Apr 24, 2019

@arichiardi do you need those builds to be brought back? It was making CI slow and I removed them.

Feel free to add them back if you feel they're useful.

Show resolved Hide resolved build.boot Outdated
@@ -9,6 +9,7 @@ const embed = require('./embed');

const argv = process.argv.slice(0);
const nodeVersion = argv[2];
const staticBinary = /^true$/.test(argv[3]);

This comment has been minimized.

Copy link
@anmonteiro

anmonteiro Apr 24, 2019

Owner

this is getting a little ugly. At which point to we actually switch to parsing CLI arguments?

This comment has been minimized.

Copy link
@arichiardi

arichiardi Apr 24, 2019

Author Collaborator

agree...maybe next PR? 👅

Show resolved Hide resolved scripts/package.js Outdated

@arichiardi arichiardi force-pushed the static-build branch from d43c8c8 to 9cca566 Apr 25, 2019

@arichiardi

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 25, 2019

AppVeyor is failing but I don't think it is related to this one:

java.io.IOException: Couldn't delete C:\Users\appveyor\.boot\cache\tmp\projects\lumo\1j0\u2qisy\cljs\core.cljs.cache.aot.json
...
@anmonteiro

This comment has been minimized.

Copy link
Owner

commented Apr 26, 2019

The Appveyor failure is expected:

fatal error C1060: compiler is out of heap space
@anmonteiro
Copy link
Owner

left a comment

This is fine by me, and I'm gonna merge. Feel free to add a static build step to the Linux matrix

@anmonteiro anmonteiro merged commit 1cb8c59 into master Apr 26, 2019

3 of 4 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: build-current Your tests passed on CircleCI!
Details
ci/circleci: test-js-current Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@anmonteiro anmonteiro deleted the static-build branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.