Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign to remove 3 column layout #5

Merged
merged 11 commits into from Jun 6, 2016
Merged

Redesign to remove 3 column layout #5

merged 11 commits into from Jun 6, 2016

Conversation

@annashipman
Copy link
Owner

@annashipman annashipman commented Jun 6, 2016

This is the start of a redesign. Removes the 3 column layout (both the CSS and the uses thereof). Changes the Games page to an Etc page. Rearranges the CV page slightly. Otherwise unchanged.

annashipman added 11 commits Jun 6, 2016
I haven't added new games recently, and it's now actually a really small part of what I do, so I'd prefer this page to showcase all the stuff I want to share that's not my main job.

`games.html` is not a 404 but is no longer accessible via navigation. In a future commit I will redirect it to `etc.html`.
Ideally this would be a 301 but as this site is GitHub pages I don't have any control over the server so instead using a meta refresh tag. Not ideal, but better than leaving a dead link.

[This article](https://superdevresources.com/redirects-jekyll-github-pages/) was useful.

I've styled the page as per the rest of the site for the back-up case where the redirect doesn't work, which at the moment involves duplication.
I'm going to change the whole site to two column layout (the only page that actually uses all three columns is the `cv.html` and it doesn't look great) so this commit changes it to be more how I would like it to look.

The only page using the two column layout at the moment is `etc.html`.
This simplifies the html considerably.
I should have been able to calcuate this from the 3 coloumn layout but it's pretty complicated. Another reason to remove it...
May not stay here but this is the easiest move in preparation for getting rid of the three column layout.
I will redesign this page but this is the first step. Also am not correcting the terrible formatting at this point as it will change significantly so would be wasted effort.
This is no longer required.
The site no longer uses the 3 column layout so the comment about this is irrelevant.

This commit also removes comments about Chris Govias as the site is moving further and further away from his design. He is still awesome though.
More to do here but this is a start.
@annashipman annashipman merged commit a841707 into master Jun 6, 2016
@annashipman annashipman deleted the redesign branch Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant