Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type checking / highlighting fails when navigating to PackageDescription from Package.juvix #2525

Closed
paulcadman opened this issue Nov 21, 2023 · 0 comments · Fixed by #2526
Closed

Type checking / highlighting fails when navigating to PackageDescription from Package.juvix #2525

paulcadman opened this issue Nov 21, 2023 · 0 comments · Fixed by #2526
Assignees
@paulcadman
Labels
bug package-manager pending-review
Milestone
0.5.5

Comments

@paulcadman
Copy link
Collaborator

After the fix:

The PackageDescription.{V1, Basic} modules cannot be type checked / highlighted. Users navigate to these modules by using jump-to-definition from a Package.juvix file.

You can reproduce this on the CLI:

$ juvix typecheck ~/.config/juvix/0.5.4/package/PackageDescription/V1.juvix
~/.config/juvix/0.5.4/package/PackageDescription/V1.juvix:1:8-29: error:
The top module PackageDescription.V1 is defined in the file:
~/.config/juvix/0.5.4/package/PackageDescription/V1.juvix
But it should be in the file:
~/.config/juvix/0.5.4/global-project/PackageDescription/V1.juvix
@paulcadman paulcadman self-assigned this Nov 21, 2023
@paulcadman paulcadman added this to the 0.5.5 milestone Nov 21, 2023
@paulcadman paulcadman mentioned this issue Nov 21, 2023
Merged
paulcadman added a commit that referenced this issue Nov 21, 2023
@paulcadman
Fix the global 'package' package so that modules within it can be typ…
c6586a9 
…e-checked independently (#2526)

This PR adds a Package.juvix file to the global 'package' package (that
is the package containing the `PackageDescription.{Basic, V1}` modules.

This means that users can now go-to-definition on Package.juvix types
and identifiers and navigate to fully highlighted
`PackageDescription.{Basic, V1}` modules.

* Closes #2525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulcadman paulcadman

Labels
bug package-manager pending-review
Projects
None yet
Milestone
0.5.5
1 participant
@paulcadman