Refactor Node datatype #1501
Merged
Refactor Node datatype #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
force-pushed
the
core-refactor
branch
from
eaff471
to
83d3752
Compare
janmasrovira
requested changes
Aug 31, 2022
lukaszcz
force-pushed
the
core-refactor
branch
from
41e9481
to
46fea7a
Compare
lukaszcz
force-pushed
the
core-refactor
branch
from
d197536
to
b6ed847
Compare
lukaszcz
force-pushed
the
core-refactor
branch
from
b6ed847
to
a2056df
Compare
janmasrovira
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring of the Node datatype. Introduces a separate datatype for each constructor containing all constructor arguments. Node helper constructor functions added in Core/Extra/Base.hs: mkVar, mkIdent, mkApp, ...