Adding smart edit#2832
Closed
SimplyYourAverageDev wants to merge 0 commit into
Closed
Conversation
|
Does this supersede #1916 ? |
github-actions
Bot
force-pushed
the
dev
branch
from
f16de3d to
cc0d460
Compare
Author
Well I'm not sure, their implementation only supports Morph API and also doesn't do diff at all so... |
Author
|
@thdxr @adamdotdevin Any chance you would consier this merge? |
Contributor
|
Thanks for implementing the smart_edit tool—it seems great for handling complex code edits! Just a concern: since it uses OpenRouter's morph/morph-v3-large model, users not set up with OpenRouter might run into failures if the main LLM picks this tool, which could disrupt their experience. Perhaps we could make the tool available only when OpenRouter is configured, or adjust the LLM's tool selection to avoid preferring it over the existing edit tool? |
Contributor
|
#1916 |
Contributor
|
@thdxr ? |
github-actions
Bot
force-pushed
the
dev
branch
from
772b621 to
eb855e1
Compare
SimplyYourAverageDev
force-pushed
the
dev
branch
from
88e6c77 to
a6b066b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds "smart edit" which basically uses Morph V3 Large (an LLM specified for applying code edits) so that the main LLM can sometimes apply edits that are hard to describe.