fix(mcp): bind oauth callback to IPv4 loopback#30022
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30013
Type of change
What does this PR do?
The MCP OAuth callback server used
server.listen(port)without a host. On Linux this can bind to the IPv6 wildcard address. In WSL2, callbacks opened in the Windows browser can fail to reach that socket through localhost forwarding.This binds the callback server to
127.0.0.1explicitly, matching the default redirect URI and keeping the server loopback-only. The port-in-use probe already checks127.0.0.1, so startup detection and the actual listener now use the same address family.How did you verify your code works?
bun --cwd packages/opencode test test/mcp/oauth-callback.test.tsbun run --cwd packages/opencode typecheckbunx prettier --check packages/opencode/src/mcp/oauth-callback.ts packages/opencode/test/mcp/oauth-callback.test.tsbunx oxlint packages/opencode/src/mcp/oauth-callback.ts packages/opencode/test/mcp/oauth-callback.test.tsgit diff --checkScreenshots / recordings
No screenshot. This changes local OAuth callback socket binding, not UI layout.
Checklist