fix: improve windows support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
May 3, 2024
| // Passing "--help "sdfsd"" to a batch script | ||
| // will be considered as a single argument made | ||
| // of --help "sdfsd". However, there are corner cases. | ||
| std::string escaped = "\"" + escaped + "\""; |
There was a problem hiding this comment.
We need to also escape " characters with \" and update cctest/node_task_runner.cc file
There was a problem hiding this comment.
We need to also escape " characters with "
Do you have a reference that says so? I don't think it works this way:
https://stackoverflow.com/questions/7760545/escape-double-quotes-in-parameter
There was a problem hiding this comment.
That's nice. TIL. Can you also update cctest/node_task_runner.cc
There was a problem hiding this comment.
So "Tim says, ""Hi!""" and "Tim says, "Hi!"" become Tim says, "Hi!". There is a fairly complex algorithm that spans quite a few paragraphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might help a little bit.