Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug 1712 #214

Merged
merged 1 commit into from Jun 12, 2018

Conversation

Projects
None yet
2 participants
@genius3000
Copy link
Contributor

genius3000 commented Feb 14, 2018

The not explicitly checked for (chan,user)modes in their inital CAPAB string are added to a list to be properly added as a Mode during the CAPABILITIES line. The logic for both CHANMODES and USERMODES needs the commasepstream to allow empty values to correctly match up at times.
For example: USERMODES=,,s,BHIRSWcdghikorwx had the first token returned as s and second token as BHIRSWcdghikorwx but the code ignores the first two tokens.
Allowing empty values matches things up properly no matter the modes available on Insp and fixes OS UMODE not working for "extra" modes. Usermode 's' (snomask) was also unable to be set/unset with OS UMODE previously and can be now (though you still can't set the parameters this way, only set/unset the mode).

Allow empty values in InspIRCd 2.0 mode strings within CAPABILITIES
Skipping over empty values in the commasepstream can put the mode adding
logic out of order (eg. ignoring the first two tokens when they are the
needed tokens). Most modes are already added by being explicitly checked
for, but the "unknown" or "extra" modes are added here.

@Adam- Adam- merged commit ce7c266 into anope:2.0 Jun 12, 2018

@genius3000 genius3000 deleted the genius3000:2.0+fix_insp20_proto branch Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.