Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle S2S AWAY messages with a timestamp #225

Merged
merged 1 commit into from Jan 4, 2019

Conversation

@genius3000
Copy link
Contributor

commented Jul 19, 2018

InspIRCd 2.0 sends a timestamp in its S2S AWAY message since
inspircd/inspircd@b1002b7
Syntax of AWAY <timestamp> :<away msg>
Catch this message and remove the timestamp parameter before
sending it to the core AWAY handler.

Tested successfully.

Edit: Changed to a modification of the inspircd20 protocol instead of core.

@SaberUK

This comment has been minimized.

Copy link
Member

commented Jul 20, 2018

I think the usual way to do this is to reimplement it in the protocol module rather than editing the core?

@genius3000

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2018

Looked at that, but it would be duplicating the code for one tiny difference. Granted it would be safer incase any others add parameters after the awaymsg.
Edit looking again, I should be able to keep it minimal in the protocol module, send the proper params to the core handler.

Handle S2S AWAY messages with a timestamp
InspIRCd 2.0 sends a timestamp in its S2S AWAY message since
inspircd/inspircd@b1002b7
Syntax of `AWAY <timestamp> :<away msg>`
Catch this message and remove the timestamp parameter before
sending it to the core AWAY handler.

@genius3000 genius3000 force-pushed the genius3000:2.0+away_msg branch from a11130e to 1e9d959 Jul 20, 2018

@Adam- Adam- merged commit a5eaf6f into anope:2.0 Jan 4, 2019

@genius3000 genius3000 deleted the genius3000:2.0+away_msg branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.