New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow post-handshake SASL in UnrealIRCd 4.2.2 and up. #235

Merged
merged 3 commits into from Feb 9, 2019

Conversation

Projects
None yet
3 participants
@syzop
Copy link
Contributor

syzop commented Feb 9, 2019

This updates the unreal4 protocol module to work with both pseudo-id's
and real UID's. Something that will also be necessary once UnrealIRCd
gets rid of pseudo-id's altogether.

Allow post-handshake SASL in UnrealIRCd 4.2.2 and up.
This updates the unreal4 protocol module to work with both pseudo-id's
and real UID's. Something that will also be necessary once UnrealIRCd
gets rid of pseudo-id's altogether.
@syzop

This comment has been minimized.

Copy link
Contributor Author

syzop commented Feb 9, 2019

Until now anope assumed pseudo-id's with the ! separator etc (simply copied from 3.2.x, which is understandable as we did so as well).
This PR changes it so that if there is no "!" character in the target then we do a server hunt for the first 3 characters. This is similar to what the charybdis protocol module does, but then in a backward compatible way.

If you need additional information or have doubts about part of the code, let me know. I have of course tested it with both pre-auth (with PUID) and post-auth (with UID), but I must also say I am not very familiar with the anope source code nor with C++ in general.

Oh, and, eventually I would like to drop PUID's altogether, but this won't be anytime soon, say a few years of now. So eventually the change will be useful even with authentication during the handshake phase as well.

Thanks!

Show resolved Hide resolved modules/protocol/unreal4.cpp Outdated
Show resolved Hide resolved modules/protocol/unreal4.cpp Outdated

Adam- and others added some commits Feb 9, 2019

Update modules/protocol/unreal4.cpp
Co-Authored-By: syzop <syzop@vulnscan.org>
Update modules/protocol/unreal4.cpp
Co-Authored-By: syzop <syzop@vulnscan.org>
@jesopo

This comment has been minimized.

Copy link

jesopo commented Feb 9, 2019

:shipit:

@Adam- Adam- merged commit da6e273 into anope:2.0 Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment