Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1627. #94

Merged
merged 1 commit into from Dec 29, 2014

Conversation

@webczat
Copy link
Contributor

commented Dec 11, 2014

It required that the FHost message was rewritten for the insp20 protocol module instead of relying on inspircd12's version.
The insp20 version internally removes +x mode on host change.

It required that the FHost message was rewritten for the insp20 protocol module instead of relying on inspircd12's version.
The insp20 version internally removes +x mode on host change.
Adam- added a commit that referenced this pull request Dec 29, 2014
Fix issue 1627.
@Adam- Adam- merged commit e88925e into anope:2.0 Dec 29, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@Adam-

This comment has been minimized.

Copy link
Member

commented Mar 11, 2015

What problems were you seeing prior to this commit? This is causing bug #1635

@webczat

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2015

I am not quite sure if I remember it right, but the issue was probably that when inspircd accepted a host change from external sources, it automatically assumed +x being removed. But the mode change was not synced, and this caused anope to leave +x set even when the rest of the network saw it unset. The only thing that was sent to every server was a host change itself and all servers would internally -x the user.

@Adam-

This comment has been minimized.

Copy link
Member

commented Mar 11, 2015

I found it, this PR is for bug #1627. I'm going to reorder this so -x is set first before setting the vhost to fix #1635.

@webczat

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2015

Well, and it seems I found why that happened (in code)... internally removing +x cleared the vhost, right? so what the fhost handler did was nullified few lines later...

@Adam-

This comment has been minimized.

Copy link
Member

commented Mar 11, 2015

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.