New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to nom 4.0.0 #24

Merged
merged 1 commit into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@Geal
Contributor

Geal commented Oct 1, 2018

Hello!

nom 4.0.0-beta1 was released in February, but nom 4.0.0 was released in May, with quite a lot of optimizations, so I'd be more interested in tracking that one :)

@anp

This comment has been minimized.

Owner

anp commented Oct 1, 2018

Hi!

Makes sense -- from lolbench's perspective they're both perfectly valid benchmarks to track and the current setup is built with the assumption that the benchmark suite is append-only.

Of course we don't want to miss out on measuring any relevant optimizations from the final 4.0.0 release. Since we haven't been running the beta1 benchmarks for all that long, I'm inclined to do this rename as is but I need to double check that we won't end up confusingly rendering results for both crates on the website.

@anp anp merged commit 5aea2f1 into anp:master Oct 4, 2018

@anp

This comment has been minimized.

Owner

anp commented Oct 4, 2018

Let's go for it, and since we aren't doing fully automated deployments yet I'll have a chance to make sure nothing weird happens before this goes live. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment