-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake moxie::cache disables gc within passed function
#238
Comments
|
I've reproduced this and I see the problem -- the DepNode for the once() call is unconditionally inheriting the liveness from the cache() node upon which its depended, but this is obviously incorrect in cases where the cache() call executes the closure on the same revision that once()'s DepNode hasn't been called. I think the solution is to store when a node was last actively traversed, and to not inherit liveness until it's been "dormant" for at least one revision. |
Code to reproduce varying behavior (uncomment lines):
This code produces:
However if you uncomment every line of code, i.e. wrap root's body with moxie::cache, which would be recached on every run bc of argument counter i, you'll get:
The text was updated successfully, but these errors were encountered: