Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake win fixes #6

Merged
merged 2 commits into from Jun 2, 2018

Conversation

@deyan-hadzhiev
Copy link
Collaborator

commented Jun 1, 2018

No description provided.

* This doesn't seem to be the real issue, but it is always good idea to
  have the CXX flags predefined as early as possible.
* Make the check for existing scene file after the command line was
  parsed to also include existance check of the initially set scene. In
  case of the CMake configuration, even it does not exist, because the
  default working dir for the debugged process is not the root of the
  repository.
* Add a check for successfull scene parsing and abort the rest of the
  main function if the scene was not parsed properly.
@anrieff anrieff merged commit 94efb03 into master Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.