Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loadbalancer resources #25

Merged
merged 11 commits into from
Mar 2, 2022
Merged

Loadbalancer resources #25

merged 11 commits into from
Mar 2, 2022

Conversation

Overglazed
Copy link
Contributor

No description provided.

0x4c6565
0x4c6565 requested changes Feb 17, 2022
View reviewed changes
Copy link
Member

@0x4c6565 0x4c6565 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments :)

ecloud/data_source_loadbalancer_network.go Outdated Show resolved Hide resolved
docs/data-sources/ecloud_loadbalancer_network.md Outdated Show resolved Hide resolved
ecloud/resource_loadbalancer.go Show resolved Hide resolved
ecloud/resource_loadbalancer.go Show resolved Hide resolved
ecloud/resource_loadbalancer_network.go Outdated Show resolved Hide resolved
ecloud/resource_loadbalancer_network.go Outdated Show resolved Hide resolved
Overglazed
Overglazed commented Feb 17, 2022
View reviewed changes
Copy link
Contributor Author

@Overglazed Overglazed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolving pr comments

ecloud/data_source_loadbalancer_network.go Outdated Show resolved Hide resolved
ecloud/resource_loadbalancer_network.go Outdated Show resolved Hide resolved
ecloud/resource_loadbalancer_network.go Outdated Show resolved Hide resolved
@Overglazed
Copy link
Contributor Author

Would help if I added forceNew to the correct resource!

Should be good now to rereview @0x4c6565 :)

0x4c6565
0x4c6565 approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@0x4c6565 0x4c6565 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just dropped a single comment

@Overglazed Overglazed merged commit b4744b6 into master Mar 2, 2022
@Overglazed Overglazed deleted the loadbalancer-resources branch March 2, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4c6565 0x4c6565 0x4c6565 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Overglazed @0x4c6565