This repository has been archived by the owner. It is now read-only.

remove external jQuery #5

Closed
frischmilch opened this Issue Jun 18, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@frischmilch
Contributor

frischmilch commented Jun 18, 2012

I would prefer if we don't refer to an external version of jQuery

    <!-- If you are not using jQuery remove the following two lines of code -->
    <script src="//ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js"></script>
    <script>window.jQuery || document.write('<script src="js/jquery-1.7.2.min.js"><\/script>')</script>

and simply point to the included version.
When HTMLcontent is viewed inside a DPS publication, the loading holds during checking for external javascript, when the iPad is connected to the internet. if the connection is slow the timeout or the OK result might be too long, then the immediate experience of the HTML widget is gone inside the magazine.

also, many magazines are read offline anyway.

@anselmh

This comment has been minimized.

Show comment Hide comment
@anselmh

anselmh Jun 18, 2012

Owner

This is valid but I want to defer this until jQuery 1.8 is out and has the ability to get a customized version of jQuery. This saves filesize for unneeded jQuery functions.

Owner

anselmh commented Jun 18, 2012

This is valid but I want to defer this until jQuery 1.8 is out and has the ability to get a customized version of jQuery. This saves filesize for unneeded jQuery functions.

@frischmilch

This comment has been minimized.

Show comment Hide comment
@frischmilch

frischmilch Jun 18, 2012

Contributor

ok great. wouldnt it be awesome to have our own custom builder for this
boilerplate? maybe too much to wish for this little project ;-)

(mobil gesendet)

Contributor

frischmilch commented Jun 18, 2012

ok great. wouldnt it be awesome to have our own custom builder for this
boilerplate? maybe too much to wish for this little project ;-)

(mobil gesendet)

@anselmh

This comment has been minimized.

Show comment Hide comment
@anselmh

anselmh Jun 18, 2012

Owner

It would be awesome but will be a huge separate milestone. Please fill a separate bug.

Owner

anselmh commented Jun 18, 2012

It would be awesome but will be a huge separate milestone. Please fill a separate bug.

frischmilch added a commit that referenced this issue Jun 27, 2012

using jQuery1.8b1
inspired by dhgamache/Cinderblock:
- adding jquery 1.8b1
- closing #5: reference jQuery locally
+ gitignore

Signed-off-by: Johannes Henseler <johannes@nordsueddesign.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.