This repository was archived by the owner on Jul 17, 2020. It is now read-only.
Added a method to add the screen shot image as base64 string in the report #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Attached the sample report generated using the new method addBase64ScreenShot() |
Collaborator
Author
|
@anshooarora : Please review |
Owner
|
Merged, this is a good addition. |
|
Hi Vimal, Can you please share the code how you captured the snap using the Base64 and stored to a server. since am getting the snap in the report in my machine & not able to see the same in other machine. Am also having the same problem as you hava, while sharing the image files. Thanks, |
|
@aonarun Here's the files he has added through this pull request. https://github.com/anshooarora/extentreports-java/pull/384/commits/50c9ed8a376dd74fbd963651393c23da1577fe64 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the extent report support to add the screen shot image as file. This PR proposes a new method to add the screen shot image as base64 string.
Why?
Most of the times, we send the report through email. This needs the image files also zipped together with the report html file. To avoid this, the user can use the base64 string of the png image file and add that in a report file using the method provided.
This solves the problem of email-able report also. 100% single report file.
Also, added the unit test package using which we can test the pieces of code. Currently, just added the unit test only for this method. I'll try to come up with unit tests for other methods in my future PRs.