New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a method to add the screen shot image as base64 string in the report #384

Merged
merged 1 commit into from Mar 23, 2016

Conversation

Projects
None yet
4 participants
@email2vimalraj
Collaborator

email2vimalraj commented Mar 21, 2016

Currently, the extent report support to add the screen shot image as file. This PR proposes a new method to add the screen shot image as base64 string.

Why?
Most of the times, we send the report through email. This needs the image files also zipped together with the report html file. To avoid this, the user can use the base64 string of the png image file and add that in a report file using the method provided.
This solves the problem of email-able report also. 100% single report file.

Also, added the unit test package using which we can test the pieces of code. Currently, just added the unit test only for this method. I'll try to come up with unit tests for other methods in my future PRs.

@email2vimalraj

This comment has been minimized.

Collaborator

email2vimalraj commented Mar 21, 2016

Attached the sample report generated using the new method addBase64ScreenShot()
report.html.zip

@email2vimalraj

This comment has been minimized.

Collaborator

email2vimalraj commented Mar 21, 2016

@anshooarora : Please review

@anshooarora anshooarora merged commit 8719e4f into anshooarora:master Mar 23, 2016

@anshooarora

This comment has been minimized.

Owner

anshooarora commented Mar 23, 2016

Merged, this is a good addition.

@aonarun

This comment has been minimized.

aonarun commented Jul 25, 2016

Hi Vimal,

Can you please share the code how you captured the snap using the Base64 and stored to a server. since am getting the snap in the report in my machine & not able to see the same in other machine. Am also having the same problem as you hava, while sharing the image files.

Thanks,
Arun

@moinuddin14

This comment has been minimized.

moinuddin14 commented Sep 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment