New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Exceptions if replaceExisting=false #388

Merged
merged 1 commit into from Mar 24, 2016

Conversation

Projects
None yet
3 participants
@6ff334e
Contributor

6ff334e commented Mar 23, 2016

Exceptions were not kept if replaceExisting was set to false.

Keep Exceptions for replaceExisting=false
Exceptions were not kept if replaceExisting was set to false.
@anshooarora

This comment has been minimized.

Show comment
Hide comment
@anshooarora

anshooarora Mar 23, 2016

Owner

Ron, this is to retain the exceptions from the previous run, correct?

Owner

anshooarora commented Mar 23, 2016

Ron, this is to retain the exceptions from the previous run, correct?

@6ff334e

This comment has been minimized.

Show comment
Hide comment
@6ff334e

6ff334e Mar 23, 2016

Contributor

@anshooarora Yes, with these changes exceptions from previous runs should be retained.

Contributor

6ff334e commented Mar 23, 2016

@anshooarora Yes, with these changes exceptions from previous runs should be retained.

@6ff334e

This comment has been minimized.

Show comment
Hide comment
@6ff334e

6ff334e Mar 23, 2016

Contributor

Should I add a config parameter to enable this explicitly? Maybe not everybody wants to retain exceptions by default.

Contributor

6ff334e commented Mar 23, 2016

Should I add a config parameter to enable this explicitly? Maybe not everybody wants to retain exceptions by default.

@anshooarora

This comment has been minimized.

Show comment
Hide comment
@anshooarora

anshooarora Mar 23, 2016

Owner

I think we should just make it a standard, it would be good for the user to know the past exceptions as well.

Owner

anshooarora commented Mar 23, 2016

I think we should just make it a standard, it would be good for the user to know the past exceptions as well.

@anshooarora

This comment has been minimized.

Show comment
Hide comment
@anshooarora

anshooarora Mar 23, 2016

Owner

quick question - Is it going to show the old exception under the exceptions list (exceptions-view)?

Owner

anshooarora commented Mar 23, 2016

quick question - Is it going to show the old exception under the exceptions list (exceptions-view)?

@anshooarora anshooarora merged commit 7b54b7d into anshooarora:master Mar 24, 2016

@email2vimalraj

This comment has been minimized.

Show comment
Hide comment
@email2vimalraj

email2vimalraj Mar 24, 2016

Collaborator

I agree with @6ff334e. It should be a config parameter. User should enable on demand.

Collaborator

email2vimalraj commented Mar 24, 2016

I agree with @6ff334e. It should be a config parameter. User should enable on demand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment