Skip to content
This repository has been archived by the owner. It is now read-only.

Keep Exceptions if replaceExisting=false #388

Merged
merged 1 commit into from Mar 24, 2016
Merged

Keep Exceptions if replaceExisting=false #388

merged 1 commit into from Mar 24, 2016

Conversation

@ghost
Copy link

@ghost ghost commented Mar 23, 2016

Exceptions were not kept if replaceExisting was set to false.

Exceptions were not kept if replaceExisting was set to false.
@anshooarora
Copy link
Owner

@anshooarora anshooarora commented Mar 23, 2016

Ron, this is to retain the exceptions from the previous run, correct?

@ghost
Copy link
Author

@ghost ghost commented Mar 23, 2016

@anshooarora Yes, with these changes exceptions from previous runs should be retained.

@ghost
Copy link
Author

@ghost ghost commented Mar 23, 2016

Should I add a config parameter to enable this explicitly? Maybe not everybody wants to retain exceptions by default.

@anshooarora
Copy link
Owner

@anshooarora anshooarora commented Mar 23, 2016

I think we should just make it a standard, it would be good for the user to know the past exceptions as well.

@anshooarora
Copy link
Owner

@anshooarora anshooarora commented Mar 23, 2016

quick question - Is it going to show the old exception under the exceptions list (exceptions-view)?

@anshooarora anshooarora merged commit 7b54b7d into anshooarora:master Mar 24, 2016
@email2vimalraj
Copy link
Collaborator

@email2vimalraj email2vimalraj commented Mar 24, 2016

I agree with @6ff334e. It should be a config parameter. User should enable on demand.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants