New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the width for the first 2 columns specific to particular table instead of applying to all table #835

Merged
merged 1 commit into from Apr 3, 2017

Conversation

Projects
None yet
2 participants
@email2vimalraj
Collaborator

email2vimalraj commented Mar 31, 2017

Currently the 60 px for the 1st column and 110 px for the 2nd column for all tables under the step view is being applied. Due to this when we use test.info(MarkupHelper.createTable(data)), the same width size is being applied, that makes the markup table created by user looks not elegant.

So added a constraint to apply the 60px and 110px only to the table-results table, not for everything.

@email2vimalraj email2vimalraj added the bug label Mar 31, 2017

@email2vimalraj email2vimalraj self-assigned this Mar 31, 2017

@email2vimalraj email2vimalraj requested a review from anshooarora Mar 31, 2017

@anshooarora

This comment has been minimized.

Owner

anshooarora commented Mar 31, 2017

I haven't tested but I believe, we can simply do:

.node-steps > table > td:first-child

instead of:

.node-steps td:first-child
@email2vimalraj

This comment has been minimized.

Collaborator

email2vimalraj commented Mar 31, 2017

.node-steps td:first-child

I'm not doing this anywhere.

For example, it was like this earlier:

.node-steps th:first-child, .node-steps td:first-child

and now I changed it to:

.node-steps > .table-results > thead > tr > th:first-child

I believe you are also referring the same thing. If I'm misunderstanding, kindly add a comment on the particular line please.

@@ -395,10 +395,10 @@ nav ul i {
.test-steps, .category-tests, .exception-tests, .test-content > .node-list {
margin-top: 30px;
}
.test-steps th:first-child, tr.log > td:first-child, .node-steps th:first-child, .node-steps td:first-child {
.test-steps th:first-child, tr.log > td:first-child, .node-steps > .table-results > thead > tr > th:first-child, .node-steps > .table-results > tbody > tr > td:first-child {

This comment has been minimized.

@anshooarora

anshooarora Mar 31, 2017

Owner

Instead of adding multiple levels to the hierarchy here, you can simply do:

.node-steps > table > td:first-child

This comment has been minimized.

@email2vimalraj

email2vimalraj Apr 3, 2017

Collaborator

No this will not work, because the .node-steps > table > td:first-child will select all the 1st td elements whose parent is table. But in our case the parent is tr, not table. That is why the chaining here.

@anshooarora anshooarora merged commit 30ea55b into master Apr 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@anshooarora

This comment has been minimized.

Owner

anshooarora commented Apr 3, 2017

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment