Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_instance - validate options on tower_callback #1199

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 25, 2022

Depends-On: #1202

SUMMARY
  • Validate options for tower_callback parameter
  • Set tower_callback.set_password (the password) to no_log=True
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

@tremble tremble requested a review from jillr October 25, 2022 19:34
@github-actions
Copy link

github-actions bot commented Oct 25, 2022

Docs Build 📝

Thank you for contribution!

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module module_utils module_utils needs_triage new_plugin New plugin plugins plugin (any type) tests tests labels Oct 25, 2022
@tremble tremble requested a review from goneri October 25, 2022 19:41
@tremble tremble marked this pull request as ready for review October 25, 2022 19:41
@tremble tremble added the backport-5 PR should be backported to the stable-5 branch label Oct 25, 2022
@tremble tremble added the backport-4 PR should be backported to the stable-4 branch label Oct 25, 2022
@softwarefactory-project-zuul

This comment has been hidden.

@softwarefactory-project-zuul

This comment has been hidden.

@softwarefactory-project-zuul

This comment has been hidden.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 5m 25s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 33s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 25s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 09s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 03s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 38s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 06s
✔️ cloud-tox-py3 SUCCESS in 3m 20s
✔️ ansible-test-splitter SUCCESS in 2m 35s
✔️ integration-amazon.aws-1 SUCCESS in 46m 43s
✔️ integration-amazon.aws-2 SUCCESS in 46m 23s
✔️ integration-amazon.aws-3 SUCCESS in 54m 35s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 25s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Oct 26, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

@tremble
Copy link
Contributor Author

tremble commented Oct 26, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

✔️ ansible-galaxy-importer SUCCESS in 4m 53s
✔️ build-ansible-collection SUCCESS in 5m 17s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 21s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 11s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 50s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 22s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 06s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 51s
✔️ cloud-tox-py3 SUCCESS in 3m 38s
✔️ ansible-test-splitter SUCCESS in 3m 22s
✔️ integration-amazon.aws-1 SUCCESS in 42m 23s
✔️ integration-amazon.aws-2 SUCCESS in 27m 37s
integration-amazon.aws-3 FAILURE in 40m 31s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 43s

@tremble
Copy link
Contributor Author

tremble commented Oct 26, 2022

regate

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 33s
✔️ build-ansible-collection SUCCESS in 6m 02s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 41s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 41s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 54s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 28s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 10s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 06s
✔️ cloud-tox-py3 SUCCESS in 4m 13s
✔️ ansible-test-splitter SUCCESS in 3m 03s
✔️ integration-amazon.aws-1 SUCCESS in 40m 33s
✔️ integration-amazon.aws-2 SUCCESS in 34m 22s
✔️ integration-amazon.aws-3 SUCCESS in 29m 23s
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 29s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5fe427c into ansible-collections:main Oct 26, 2022
8 checks passed
@patchback
Copy link

patchback bot commented Oct 26, 2022

Backport to stable-4: 💚 backport PR created

Backport PR branch: patchback/backports/stable-4/5fe427c6f4152489b2ed7f8ede86eb9b65940922/pr-1199

Backported as #1207

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 26, 2022
ec2_instance - validate options on tower_callback

Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 5fe427c)
@patchback
Copy link

patchback bot commented Oct 26, 2022

Backport to stable-5: 💚 backport PR created

Backport PR branch: patchback/backports/stable-5/5fe427c6f4152489b2ed7f8ede86eb9b65940922/pr-1199

Backported as #1208

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 26, 2022
ec2_instance - validate options on tower_callback

Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 5fe427c)
@jillr jillr added the backport-3 PR should be backported to the stable-3 branch label Oct 26, 2022
@patchback
Copy link

patchback bot commented Oct 26, 2022

Backport to stable-3: 💚 backport PR created

Backport PR branch: patchback/backports/stable-3/5fe427c6f4152489b2ed7f8ede86eb9b65940922/pr-1199

Backported as #1210

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 26, 2022
ec2_instance - validate options on tower_callback

Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 5fe427c)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 27, 2022
[PR #1199/5fe427c6 backport][stable-5] ec2_instance - validate options on tower_callback

This is a backport of PR #1199 as merged into main (5fe427c).
Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 27, 2022
[PR #1199/5fe427c6 backport][stable-4] ec2_instance - validate options on tower_callback

This is a backport of PR #1199 as merged into main (5fe427c).
Depends-On: #1202
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 5, 2023
[PR #1199/5fe427c6 backport][stable-3] ec2_instance - validate options on tower_callback

This is a backport of PR #1199 as merged into main (5fe427c).
Depends-On: #1202
Depends-On: ansible/ansible-zuul-jobs#1734
SUMMARY

Validate options for tower_callback parameter
Set tower_callback.set_password (the password) to no_log=True

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@tremble tremble deleted the ec2_instance/tower branch February 15, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module_utils module_utils module module needs_triage new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants