-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom providers #146
Add support for custom providers #146
Conversation
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 08s |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 17s |
@gravesm I fixed the formatting error. |
@vvarga007 thanks for contributing to this collection. I added some remark. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the following note to the description on this plugin:
The Terraform providers for AWS, Azure and Google Cloud are supported by Red Hat Ansible. Other providers are supported by the community.
71f79ee
to
c10bf19
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 36s |
changelogs/fragments/20240628-inventory-terraform_state-custom-providers.yaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 73.00% 79.52% +6.52%
==========================================
Files 16 23 +7
Lines 1015 1441 +426
Branches 182 254 +72
==========================================
+ Hits 741 1146 +405
- Misses 243 253 +10
- Partials 31 42 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c10bf19
to
083ce63
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 27s |
083ce63
to
b888478
Compare
@gravesm So close... Fixed that indentation error on the changelog YAML file. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 2m 47s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 2m 51s |
8a592e1
into
ansible-collections:main
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #154 🤖 @patchback |
SUMMARY Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP). I intend to add a way for custom provider configuration. ISSUE TYPE Feature Pull Request COMPONENT NAME terraform_state inventory plugin ADDITIONAL INFORMATION It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider. Reviewed-by: Bikouo Aubin Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Viktor Varga (cherry picked from commit 8a592e1)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #155 🤖 @patchback |
SUMMARY Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP). I intend to add a way for custom provider configuration. ISSUE TYPE Feature Pull Request COMPONENT NAME terraform_state inventory plugin ADDITIONAL INFORMATION It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider. Reviewed-by: Bikouo Aubin Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Viktor Varga (cherry picked from commit 8a592e1)
This is a backport of PR #146 as merged into main (8a592e1). SUMMARY Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP). I intend to add a way for custom provider configuration. ISSUE TYPE Feature Pull Request COMPONENT NAME terraform_state inventory plugin ADDITIONAL INFORMATION It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider. Reviewed-by: Mike Graves <mgraves@redhat.com>
SUMMARY Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP). I intend to add a way for custom provider configuration. ISSUE TYPE Feature Pull Request COMPONENT NAME terraform_state inventory plugin ADDITIONAL INFORMATION It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider. Reviewed-by: Bikouo Aubin Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Viktor Varga (cherry picked from commit 8a592e1)
This is a backport of PR #146 as merged into main (8a592e1). SUMMARY Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP). I intend to add a way for custom provider configuration. ISSUE TYPE Feature Pull Request COMPONENT NAME terraform_state inventory plugin ADDITIONAL INFORMATION It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider. Reviewed-by: Mike Graves <mgraves@redhat.com>
SUMMARY
Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP).
I intend to add a way for custom provider configuration.
ISSUE TYPE
COMPONENT NAME
terraform_state inventory plugin
ADDITIONAL INFORMATION
It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider.