Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom providers #146

Conversation

vvarga007
Copy link
Contributor

SUMMARY

Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP).
I intend to add a way for custom provider configuration.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

terraform_state inventory plugin

ADDITIONAL INFORMATION

It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider.

Copy link

Copy link

@vvarga007
Copy link
Contributor Author

@gravesm I fixed the formatting error.
I am not 100% sure how I should generate the documentation if I have to.

plugins/inventory/terraform_state.py Outdated Show resolved Hide resolved
plugins/inventory/terraform_state.py Outdated Show resolved Hide resolved
plugins/inventory/terraform_state.py Outdated Show resolved Hide resolved
@abikouo
Copy link
Contributor

abikouo commented Jun 24, 2024

@vvarga007 thanks for contributing to this collection. I added some remark.
You will also need to add a changelog file.

Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the following note to the description on this plugin:

The Terraform providers for AWS, Azure and Google Cloud are supported by Red Hat Ansible. Other providers are supported by the community.

Copy link

@vvarga007
Copy link
Contributor Author

@gravesm @abikouo I added the requested changes. Hopefully, it is good enough this time.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (8c52bf2) to head (c10bf19).
Report is 21 commits behind head on main.

Current head c10bf19 differs from pull request most recent head b888478

Please upload reports for the commit b888478 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   73.00%   79.52%   +6.52%     
==========================================
  Files          16       23       +7     
  Lines        1015     1441     +426     
  Branches      182      254      +72     
==========================================
+ Hits          741     1146     +405     
- Misses        243      253      +10     
- Partials       31       42      +11     
Flag Coverage Δ
sanity ?
units 79.52% <ø> (+6.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@vvarga007
Copy link
Contributor Author

@gravesm So close... Fixed that indentation error on the changelog YAML file.
Some pre-commit hook would be great to make it easier to pass these GitHub workflows.

Copy link

@gravesm gravesm added the mergeit label Jul 1, 2024
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/b35355b03323453abdbfe2623f0b9b3a

✔️ ansible-galaxy-importer SUCCESS in 2m 51s
✔️ build-ansible-collection SUCCESS in 6m 38s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8a592e1 into ansible-collections:main Jul 1, 2024
43 of 44 checks passed
Copy link

patchback bot commented Jul 1, 2024

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/8a592e1a80033eb4ad6c6930231223fd50a74180/pr-146

Backported as #154

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 1, 2024
SUMMARY

Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP).
I intend to add a way for custom provider configuration.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

terraform_state inventory plugin
ADDITIONAL INFORMATION

It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider.

Reviewed-by: Bikouo Aubin
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Viktor Varga
(cherry picked from commit 8a592e1)
Copy link

patchback bot commented Jul 1, 2024

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/8a592e1a80033eb4ad6c6930231223fd50a74180/pr-146

Backported as #155

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 1, 2024
SUMMARY

Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP).
I intend to add a way for custom provider configuration.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

terraform_state inventory plugin
ADDITIONAL INFORMATION

It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider.

Reviewed-by: Bikouo Aubin
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Viktor Varga
(cherry picked from commit 8a592e1)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 3, 2024
This is a backport of PR #146 as merged into main (8a592e1).
SUMMARY


Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP).
I intend to add a way for custom provider configuration.
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

terraform_state inventory plugin
ADDITIONAL INFORMATION


It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider.

Reviewed-by: Mike Graves <mgraves@redhat.com>
gravesm pushed a commit that referenced this pull request Jul 3, 2024
SUMMARY

Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP).
I intend to add a way for custom provider configuration.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

terraform_state inventory plugin
ADDITIONAL INFORMATION

It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider.

Reviewed-by: Bikouo Aubin
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Viktor Varga
(cherry picked from commit 8a592e1)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 3, 2024
This is a backport of PR #146 as merged into main (8a592e1).
SUMMARY


Currently, only three major cloud provider resources are supported. (AWS, Azure, GCP).
I intend to add a way for custom provider configuration.
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

terraform_state inventory plugin
ADDITIONAL INFORMATION


It would be great to use this plugin with other cloud providers or with on-prem cloud solutions that have an in-house-developed Terraform provider.

Reviewed-by: Mike Graves <mgraves@redhat.com>
@vvarga007 vvarga007 deleted the custom_providers branch July 11, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants