Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging - wafv2_web_acl add support for managing and purging tags #1218

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 5, 2022

SUMMARY
  • Add support for returning tags
  • Add support for updating tags
  • Add support for purge_tags
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

wafv2_web_acl
wafv2_web_acl_info

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 5, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 3m 42s (non-voting)
✔️ build-ansible-collection SUCCESS in 5m 05s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 25s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 27s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 02s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 39s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 19s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 06s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 37s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 7m 32s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR contains changes intended for this PR as well as from #1216. I can give it a proper review after they're split up!

changelogs/fragments/1216-wafv2_web_acl-return.yml Outdated Show resolved Hide resolved
@tremble
Copy link
Contributor Author

tremble commented Jun 7, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 4m 11s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 46s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 30s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 11m 12s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 58s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 00s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 32s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 46s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 07s
✔️ ansible-test-splitter SUCCESS in 2m 24s
✔️ integration-community.aws-1 SUCCESS in 8m 12s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 3m 44s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 55s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 03s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 05s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 14m 23s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 48s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 25s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 38s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 50s
✔️ ansible-test-splitter SUCCESS in 2m 57s
✔️ integration-community.aws-1 SUCCESS in 7m 17s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 8, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 44s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 42s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 16s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 13m 24s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 13m 47s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 14s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 23s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 36s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 15s
✔️ ansible-test-splitter SUCCESS in 2m 22s
✔️ integration-community.aws-1 SUCCESS in 7m 12s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2d652cc into ansible-collections:main Jun 8, 2022
@tremble tremble deleted the tagging/purge/wafv2_web_acl branch July 7, 2022 19:23
abikouo added a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
Refactor inventory plugins

SUMMARY

Refactor inventory plugins to put common code into module_utils
add unit tests for inventory aws_rds
support integration testing for aws_rds inventory

ISSUE TYPE

Bugfix Pull Request
Feature Pull Request

COMPONENT NAME

aws_rds
aws_ec2

Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: Bikouo Aubin <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants