Make mostly reuse conformant #502
Conversation
|
@gotmax23 one thing I'm very unsure about is the last commit: 35e1068 It adds Maybe you saw something similar and have an idea what to do here? |
IANAL, and I'm not exactly sure what to do here. I guess you have three options:
|
|
I'm currently tending to the third option. The first two require legal advice (IMO)... I guess a better approach is to replace them by files we generate ourselves. This will take a bit of time though, but I think I'll work on that first. |
I'd lean towards adding the GPL headers (option 1). That's what was already there, even if it was implicit, so we wouldn't be changing anything. If the files aren't copyrightable, then the license is invalid, anyways. It's no different than the blank FWIW, I do remember that one of the go libraries used by docker that we package in Fedora includes a Lets Encrypt root certificate that it uses for tests, as well. The library is Apache licensed. There was no special license information attached to it. The certificate is copied straight into a |
| try: | ||
| with open(filename, 'r', encoding='utf-8') as f: | ||
| for line in f: | ||
| line = line.rstrip() | ||
| if 'Copyright ' in line: | ||
| has_copyright = True | ||
| if 'Copyright: ' in line: | ||
| print('%s: found copyright line with "Copyright:". Please remove the colon.' % (filename, )) | ||
| if 'SPDX-FileCopyrightText: ' in line: | ||
| has_copyright = True | ||
| idx = line.find('SPDX-License-Identifier: ') | ||
| if idx >= 0: | ||
| lic_id = line[idx + len('SPDX-License-Identifier: '):] | ||
| spdx_license_identifiers.extend(lic_id.split(' OR ')) | ||
| if 'GNU General Public License' in line: | ||
| if 'v3.0+' in line: | ||
| other_license_identifiers.append('GPL-3.0-or-later') | ||
| if 'version 3 or later' in line: | ||
| other_license_identifiers.append('GPL-3.0-or-later') | ||
| if 'Simplified BSD License' in line: | ||
| other_license_identifiers.append('BSD-2-Clause') | ||
| if 'Apache License 2.0' in line: | ||
| other_license_identifiers.append('Apache-2.0') | ||
| if 'PSF License' in line or 'Python-2.0' in line: | ||
| other_license_identifiers.append('PSF-2.0') | ||
| if 'MIT License' in line: | ||
| other_license_identifiers.append('MIT') | ||
| except Exception as exc: | ||
| print('%s: error while processing file: %s' % (filename, exc)) |
There was a problem hiding this comment.
So the only change here is putting it in a try-except block?
There was a problem hiding this comment.
And support for SPDX-FileCopyrightText:. The try/except block comes from community.general, the SPDX-FileCopyrightText: block change too I think, and the other projects got the OR change from this one IIRC. Basically making sure that all projects have essentially the same copy of this whole file. (The only exception is community.dns, which has a special clause for plugins/public_suffix_list.dat having a non-GPL license outside of module_utils and modules.)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
I decided to revert the controversial part of this PR so we can get it merged, and only have the controversial part left. |
|
@gotmax23 thanks for reviewing this, and your comments! |
|
The controversial parts and reverts of the last commits are in #509. |
Sure! Thank you for all of the work you've done for this change. |
SUMMARY
Everything except changelog/fragments/ is now reuse conformant (https://reuse.software/spec/).
CC @gotmax23
ISSUE TYPE
COMPONENT NAME
licensing