From 83813a30203a3124edd1c9c1c2546f26feb63b19 Mon Sep 17 00:00:00 2001 From: Lars Krahl <57526005+mmslkr@users.noreply.github.com> Date: Fri, 3 Feb 2023 11:02:14 +0100 Subject: [PATCH] Replace missing default favicon with docs.ansible.com favicon (#5928) * replace missing default favicon with docs.ansible.com * create changelog fragment for PR 5928 * move changelog fragment * fix parameter description Co-authored-by: Felix Fontein * fix parameter description Co-authored-by: Felix Fontein * add affected modules in changelog fragment Co-authored-by: Felix Fontein --------- Co-authored-by: Lars Krahl Co-authored-by: Felix Fontein (cherry picked from commit a64df658c5eb09621feffb2f6e4c6b0b14501c59) --- changelogs/fragments/5928-fix-favicon-url.yml | 2 ++ plugins/modules/mattermost.py | 6 +++--- plugins/modules/rocketchat.py | 4 ++-- plugins/modules/slack.py | 6 +++--- tests/unit/plugins/modules/test_slack.py | 2 +- 5 files changed, 11 insertions(+), 9 deletions(-) create mode 100644 changelogs/fragments/5928-fix-favicon-url.yml diff --git a/changelogs/fragments/5928-fix-favicon-url.yml b/changelogs/fragments/5928-fix-favicon-url.yml new file mode 100644 index 00000000000..eccb9f4a0f4 --- /dev/null +++ b/changelogs/fragments/5928-fix-favicon-url.yml @@ -0,0 +1,2 @@ +minor_changes: + - mattermost, rocketchat, slack - replace missing default favicon with docs.ansible.com favicon (https://github.com/ansible-collections/community.general/pull/5928). diff --git a/plugins/modules/mattermost.py b/plugins/modules/mattermost.py index af6666b3cd8..b3fe6b5680c 100644 --- a/plugins/modules/mattermost.py +++ b/plugins/modules/mattermost.py @@ -60,8 +60,8 @@ icon_url: type: str description: - - Url for the message sender's icon. - default: https://www.ansible.com/favicon.ico + - URL for the message sender's icon. + default: https://docs.ansible.com/favicon.ico validate_certs: description: - If C(false), SSL certificates will not be validated. This should only be used @@ -127,7 +127,7 @@ def main(): text=dict(type='str'), channel=dict(type='str', default=None), username=dict(type='str', default='Ansible'), - icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'), + icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'), validate_certs=dict(default=True, type='bool'), attachments=dict(type='list', elements='dict'), ), diff --git a/plugins/modules/rocketchat.py b/plugins/modules/rocketchat.py index 153567e22a1..02458ed2321 100644 --- a/plugins/modules/rocketchat.py +++ b/plugins/modules/rocketchat.py @@ -58,7 +58,7 @@ type: str description: - URL for the message sender's icon. - default: "https://www.ansible.com/favicon.ico" + default: "https://docs.ansible.com/favicon.ico" icon_emoji: type: str description: @@ -212,7 +212,7 @@ def main(): msg=dict(type='str', required=False), channel=dict(type='str'), username=dict(type='str', default='Ansible'), - icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'), + icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'), icon_emoji=dict(type='str'), link_names=dict(type='int', default=1, choices=[0, 1]), validate_certs=dict(default=True, type='bool'), diff --git a/plugins/modules/slack.py b/plugins/modules/slack.py index 2854277f60e..c1ae865cded 100644 --- a/plugins/modules/slack.py +++ b/plugins/modules/slack.py @@ -81,8 +81,8 @@ icon_url: type: str description: - - Url for the message sender's icon (default C(https://www.ansible.com/favicon.ico)) - default: https://www.ansible.com/favicon.ico + - URL for the message sender's icon (default C(https://docs.ansible.com/favicon.ico)) + default: https://docs.ansible.com/favicon.ico icon_emoji: type: str description: @@ -439,7 +439,7 @@ def main(): channel=dict(type='str'), thread_id=dict(type='str'), username=dict(type='str', default='Ansible'), - icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'), + icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'), icon_emoji=dict(type='str'), link_names=dict(type='int', default=1, choices=[0, 1]), parse=dict(type='str', choices=['none', 'full']), diff --git a/tests/unit/plugins/modules/test_slack.py b/tests/unit/plugins/modules/test_slack.py index 352d3f4b947..ab4405baa7a 100644 --- a/tests/unit/plugins/modules/test_slack.py +++ b/tests/unit/plugins/modules/test_slack.py @@ -142,7 +142,7 @@ def test_message_with_blocks(self): }, 'accessory': { 'type': 'image', - 'image_url': 'https://www.ansible.com/favicon.ico', + 'image_url': 'https://docs.ansible.com/favicon.ico', 'alt_text': 'test' } }, {