Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #1157/20f470cc backport][stable-1] Remove ansible.posix dependency #1191

Merged
merged 1 commit into from Oct 28, 2020
Merged

[PR #1157/20f470cc backport][stable-1] Remove ansible.posix dependency #1191

merged 1 commit into from Oct 28, 2020

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 28, 2020

This is a backport of PR #1157 as merged into main (20f470c).

SUMMARY

As mentioned here by vendoring the one file used by the filesystem module.

(Also part of #354.)

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

filesystem
collection

@felixfontein
Remove ansible.posix dependency (#1157)
5026cbd 
* Vendor plugins/module_utils/mount.py from ansible.posix, and drop ansible.posix dependency (except for testing).

* Add ignore.txt entries.

* Install test requirements conditionally.

* Apply suggestions from code review

Co-authored-by: John R Barker <john@johnrbarker.com>

* Bump to major changes.

Co-authored-by: John R Barker <john@johnrbarker.com>
(cherry picked from commit 20f470c)
@ansibullbot
Copy link
Collaborator

cc @MorrisA @bcoca @d-little @flynn1973 @gforster @gundalow @kairoaraujo @marvin-sinister @mator @molekuul @ramooncamacho @wtcross
click here for bot help

@ansibullbot ansibullbot added affects_2.10 bug This issue/PR relates to a bug community_review module module module_utils module_utils needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests unit tests/unit labels Oct 28, 2020
@felixfontein felixfontein mentioned this pull request Oct 28, 2020
Closed
felixfontein
felixfontein requested changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative review to prevent accidental merging until this has been discussed at the community meeting.

@ansibullbot ansibullbot added has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Oct 28, 2020
@acozine acozine mentioned this pull request Oct 28, 2020
Closed
felixfontein
felixfontein approved these changes Oct 28, 2020
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed in ansible/community#539 (comment) this can be merged.

@felixfontein felixfontein merged commit 6708ee1 into stable-1 Oct 28, 2020
@felixfontein felixfontein deleted the patchback/backports/stable-1/20f470cc6491087e739c00f3a7429079b57c36e9/pr-1157 branch October 28, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
affects_2.10 bug This issue/PR relates to a bug has_issue module_utils module_utils module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) system tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ansibullbot @felixfontein