Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add myself to commit-rights.md #2739

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

aminvakil
Copy link
Contributor

SUMMARY

See title 馃帀 !

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the great and regular contribution!
at least 152 merged PRs to the ansible-collections org, 3 open, and great review history is definitely a great achievement!

@ansibullbot ansibullbot added affects_2.10 community_review needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging labels Jun 7, 2021
@felixfontein felixfontein merged commit 1e34df7 into ansible-collections:main Jun 7, 2021
@patchback
Copy link

patchback bot commented Jun 7, 2021

Backport to stable-1: 馃挌 backport PR created

鉁 Backport PR branch: patchback/backports/stable-1/1e34df7ca05c729b29dd27d45d1fa68b0bc87640/pr-2739

Backported as #2740

馃 @patchback
I'm built with octomachinery and
my source is open 鈥 https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 7, 2021
(cherry picked from commit 1e34df7)
@patchback
Copy link

patchback bot commented Jun 7, 2021

Backport to stable-2: 馃挌 backport PR created

鉁 Backport PR branch: patchback/backports/stable-2/1e34df7ca05c729b29dd27d45d1fa68b0bc87640/pr-2739

Backported as #2741

馃 @patchback
I'm built with octomachinery and
my source is open 鈥 https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 7, 2021
(cherry picked from commit 1e34df7)
@patchback
Copy link

patchback bot commented Jun 7, 2021

Backport to stable-3: 馃挌 backport PR created

鉁 Backport PR branch: patchback/backports/stable-3/1e34df7ca05c729b29dd27d45d1fa68b0bc87640/pr-2739

Backported as #2742

馃 @patchback
I'm built with octomachinery and
my source is open 鈥 https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@aminvakil thanks for joining the team! :)
@Andersson007 thanks for organizing this!

patchback bot pushed a commit that referenced this pull request Jun 7, 2021
(cherry picked from commit 1e34df7)
@Andersson007
Copy link
Contributor

@aminvakil you're with triage -> write. BTW you can remove your login from supershipit at the top (IIRC) of BOTMETA.yml because it's no longer needed.

@aminvakil aminvakil deleted the committers branch June 7, 2021 13:53
felixfontein pushed a commit that referenced this pull request Jun 7, 2021
(cherry picked from commit 1e34df7)

Co-authored-by: Amin Vakil <info@aminvakil.com>
felixfontein pushed a commit that referenced this pull request Jun 7, 2021
(cherry picked from commit 1e34df7)

Co-authored-by: Amin Vakil <info@aminvakil.com>
felixfontein pushed a commit that referenced this pull request Jun 7, 2021
(cherry picked from commit 1e34df7)

Co-authored-by: Amin Vakil <info@aminvakil.com>
@Andersson007
Copy link
Contributor

cc @russoz I wrote to you in IRC but in case you'll miss it, feel free to create the same PR for yourself!
Please let me know after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_triage small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants