Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy test setup #191

Merged

Conversation

briantist
Copy link
Collaborator

SUMMARY

This PR removes the "legacy" integration test option, that downloaded Vault and tinyproxy locally.

It provided ease of use, where contributors could simply rename the sample integration config and run tests, but it was very slow if you needed to run multiple targets. It's also tough to maintain.

I want to introduce additional software needed, such as MMock, an additional Vault instance or two (Agent mode, perhaps a separate writable instance), toxiproxy, possible an LDAP server, etc. Every one of these would require additional direct install support to continue supporting the legacy mode.

The docker-based localenv is much simpler to add additional software onto, as it's just a matter of additional containers to the config.

This PR also:

ISSUE TYPE
  • CI/tests Pull Request
COMPONENT NAME

tests/CI

ADDITIONAL INFORMATION

@briantist briantist added tests Adds or modifies tests ci Specifically related to the CI on this repo labels Nov 13, 2021
@briantist briantist self-assigned this Nov 13, 2021
@briantist briantist added this to In progress in CI and Testing Improvements Nov 13, 2021
@briantist briantist temporarily deployed to docs-build November 13, 2021 17:03 Inactive
@github-actions
Copy link

github-actions bot commented Nov 13, 2021

##Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://community-hashi-vault-main.surge.sh

@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #191 (90737f3) into main (d46c544) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   91.69%   91.69%           
=======================================
  Files          40       40           
  Lines        1589     1589           
  Branches      122      122           
=======================================
  Hits         1457     1457           
  Misses        119      119           
  Partials       13       13           
Flag Coverage Δ
env_docker-default 91.69% <ø> (ø)
integration 75.59% <ø> (ø)
sanity 37.65% <ø> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 66.62% <ø> (ø)
target_import 37.65% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_module_utils 90.17% <ø> (ø)
target_module_vault_read 92.10% <ø> (ø)
units 88.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46c544...90737f3. Read the comment docs.

@briantist briantist moved this from In progress to Done in CI and Testing Improvements Nov 13, 2021
@briantist briantist merged commit 5117d42 into ansible-collections:main Nov 13, 2021
@briantist briantist added this to the v2.1.0 milestone Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Specifically related to the CI on this repo tests Adds or modifies tests
Development

Successfully merging this pull request may close these issues.

integration_tests - cleanup aliases
1 participant