Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashi_vault - add env and vars for userpass options #96

Merged
merged 2 commits into from Jun 19, 2021

Conversation

briantist
Copy link
Collaborator

SUMMARY

Fixes #54

Note: still no tests for userpass, see #67

Adds env:

  • ANSIBLE_HASHI_VAULT_USERNAME
  • ANSIBLE_HASHI_VAULT_PASSWORD

Add ansible vars:

  • ansible_hashi_vault_username
  • ansible_hashi_vault_password
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hashi_vault

ADDITIONAL INFORMATION

@briantist briantist added the enhancement New feature or request label Jun 18, 2021
@briantist briantist added this to the v1.2.0 milestone Jun 18, 2021
@briantist briantist self-assigned this Jun 18, 2021
@briantist
Copy link
Collaborator Author

cc @nwerker

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #96 (baa637c) into main (5a71552) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files          16       16           
  Lines         787      787           
  Branches       78       78           
=======================================
  Hits          653      653           
  Misses        120      120           
  Partials       14       14           
Impacted Files Coverage Δ
plugins/lookup/hashi_vault.py 63.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a71552...baa637c. Read the comment docs.

@briantist briantist merged commit 2dc5741 into ansible-collections:main Jun 19, 2021
@briantist briantist moved this from In progress to Done in Environment Variable Standardization Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

hashi_vault - lookup plugin should allow environment variables for Username / Password auth
2 participants