-
Notifications
You must be signed in to change notification settings - Fork 112
postgresql_privs: add support for alter default privileges grant usage on schemas #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@caseyandgina @hunleyd could you take a look? (if you click the gear in review mode and then click "Hide whitespaces", it'll make the review easier) if you're OK with the implementation, @caseyandgina could you please thoroughly test these changes on your test infra? (you can just replace your current module file with the file from my PR) Despite passing our CI, i won't merge this w/o manual testing (I'm not a DBA). @hunleyd maybe your folks also could help with testing this? |
|
this looks ok. will test soon |
@hunleyd thanks, I'll be waiting for your feedback! |
|
@caseyandgina if you take part in testing I asked for in my previous message, it'd be much appreciated as we're touching very important module. |
|
cc @caseyandgina ^ |
|
@Andersson007 I'm sorry but I really don't know how to test as I'm not a developer. I'll need some guidance on how to do this. I have been meaning to talk to some colleagues who have more experience with Ansible, but we've been extremely busy at work lately. |
|
@caseyandgina sorry for the late reply, was in a business trip, you can test in simply by:
If you have any questions, feel free to ask |
|
@hunleyd @caseyandgina thanks for reviewing! |
SUMMARY
Fixes #332
Fixes #333
Test task 332 executes the following queries:
Test task 333 executes the following:
Is it OK?
not-specifiedis introduced to preserve backwards compatibility, we can change it as a default in a later major release if needed.ISSUE TYPE