Skip to content

postgresql_alter_system: fix values returned in scientific notation #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

postgresql_alter_system: fix values returned in scientific notation #854

merged 1 commit into from
May 15, 2025

Conversation

@Andersson007
Copy link
Collaborator

@Andersson007 Andersson007 commented May 14, 2025

SUMMARY

Fixes #853

@Andersson007 Andersson007 mentioned this pull request May 14, 2025
Closed
@Andersson007
Copy link
Collaborator Author

Andersson007 commented May 14, 2025

ready for review

@andreasscherbaum
Copy link
Collaborator

andreasscherbaum commented May 14, 2025

I think this needs more work:

ads=# set work_mem to '1.79769e+308';
ERROR:  invalid value for parameter "work_mem": "1.79769e+308"
HINT:  Value exceeds integer range.

My assumption is that the most common case for value+exponent is that the actual value is too large. And then PG will also fail.

andreasscherbaum
andreasscherbaum reviewed May 14, 2025
View reviewed changes
andreasscherbaum
andreasscherbaum approved these changes May 15, 2025
View reviewed changes
Copy link
Collaborator

@andreasscherbaum andreasscherbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All questions solved, good to merge

@hunleyd hunleyd merged commit f32de83 into ansible-collections:main May 15, 2025
29 checks passed
@Andersson007
Copy link
Collaborator Author

Andersson007 commented May 15, 2025

Thanks for reviewing, everyone!

Andersson007 added a commit to Andersson007/community.postgresql that referenced this pull request May 16, 2025
@Andersson007
postgresql_alter_system: fix values returned in scientific notation (a…
02265aa 
…nsible-collections#854)

(cherry picked from commit f32de83)
@Andersson007 Andersson007 mentioned this pull request May 16, 2025
Merged
Andersson007 added a commit that referenced this pull request May 16, 2025
@Andersson007
postgresql_alter_system: fix values returned in scientific notation (#…
8b808f3 
…854) (#855)

(cherry picked from commit f32de83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreasscherbaum andreasscherbaum andreasscherbaum approved these changes

@hunleyd hunleyd hunleyd approved these changes

@toydarian toydarian toydarian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[3.14.0] postgresql_alter_system module is trying to int a non-int param

4 participants

@Andersson007 @andreasscherbaum @hunleyd @toydarian