Avoid repeating input argument when it is mentioned as positional #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
changed the title
briantist
approved these changes
Jun 20, 2022
|
It's also worth having this merged as there's no linting tool that prevents collection maintainers from doing the same. (They'll likely then complain that we render the docs wrongly...) |
|
@briantist thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically fixes ansible/ansible#77725 on our side. (I still think this is wrong and should be highlighted by a linter, but there is no linter and if core doesn't change it, we have to accept it as-is...)