Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when destination directory does not exist #144

Merged
merged 1 commit into from Jul 22, 2020

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Jul 22, 2020

Also makes sure that the error messages already mention the other details that are checked.

Fixes #140.

Copy link

@evgeni evgeni left a comment

Didn't run the code, but from reading the diff it should prevent the crash I've been seeing and the message is clearer too. 👍

Only comment: given the same message is used multiple times, maybe make it a constant?

@felixfontein
Copy link
Collaborator Author

felixfontein commented Jul 22, 2020

It did prevent the crash at least on my system ;-) About the error messages: only part of the error messages is the same in different messages. Moving that part to a constant would thus require these part to be a separate sentence (I don't like sentence parts to be moved to constants - that increases the chances that you end up with broken language after a few edits).

@evgeni
Copy link

evgeni commented Jul 22, 2020

Oh, indeed. The diff view on mobile is not that good and I didn't see the different sentences. Ignore me them ;)

@abadger abadger merged commit 6ea51eb into ansible-community:main Jul 22, 2020
@abadger
Copy link
Contributor

abadger commented Jul 22, 2020

Merged, thanks!

@felixfontein
Copy link
Collaborator Author

felixfontein commented Jul 22, 2020

@evgeni @abadger thanks for reviewing and merging!

@felixfontein felixfontein deleted the ansible-docs-dir-check branch Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

antsibull-docs expects dest-dir to exist
3 participants