Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment Golang's GerritBot for synchronizing GitHub pull requests to Gerrit #4

Open
dmsimard opened this issue Apr 24, 2019 · 1 comment

Comments

@dmsimard
Copy link
Contributor

@dmsimard dmsimard commented Apr 24, 2019

Golang reviews patches on Gerrit while allowing pull requests to be sent.

They do this with GerritBot which takes care of synchronizing pull requests to gerrit changes.

At a first glance, it looks fairly reliable and automatically takes care of things like:

  • Squashing multiple commits from a PR to a single commit in Gerrit
  • Linking the Gerrit change to the PR (with a commit footer like GitHub-Pull-Request: golang/go#31627)
  • Re-posting comments from gerrit to github

A successful implementation would allow contributors to send pull requests to the different ARA projects.

This is what it looks like from GitHub:

Screenshot from 2019-04-24 15-58-29

And this is what it looks like from Gerrit:

Screenshot from 2019-04-24 16-00-22

@dmsimard dmsimard changed the title Experiment Golang's GerritBOt for synchronizing GitHub pull requests to Gerrit Experiment Golang's GerritBot for synchronizing GitHub pull requests to Gerrit Apr 24, 2019
@dmsimard
Copy link
Contributor Author

@dmsimard dmsimard commented Oct 28, 2020

It turns out that sqlalchemy also mirror their PRs to gerrit but they do it differently: https://news.ycombinator.com/item?id=24921021

Screenshot_20201028-150443

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant