Skip to content

Conversation

@felixfontein
Copy link
Collaborator

@felixfontein felixfontein marked this pull request as draft November 23, 2022 22:37
@felixfontein felixfontein marked this pull request as ready for review November 23, 2022 22:45
Copy link
Collaborator

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

squash-hierarchy:
description: |
If 'true', the collection documentation will be created at top-level and not in a subdirectory `namespace/collection_name/`.
This is only possible if 'collections' contains exactly one collection.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the flag is used with more than one collection?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spinx-init will complain :) You can see it here: https://github.com/ansible-community/github-docs-build/actions/runs/3536149650/jobs/5934924344 - there was a bug in the tests that collections wasn't actually passed on, and thus squash-hierarchy was used with zero collections in that case.

@felixfontein felixfontein merged commit 6fc0639 into ansible-community:main Nov 24, 2022
@felixfontein felixfontein deleted the squash-hierarchy branch November 24, 2022 19:34
@felixfontein
Copy link
Collaborator Author

@briantist thanks for reviewing!

@felixfontein
Copy link
Collaborator Author

Unfortunately this introduced bugs into the shared workflows, see #59 for a fix.

@felixfontein
Copy link
Collaborator Author

#60 had another one. But now it works, see https://ansible-collections.github.io/community.dns/branch/main/ for the result.

@felixfontein felixfontein mentioned this pull request Nov 24, 2022
@felixfontein
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants