This repository was archived by the owner on Oct 9, 2024. It is now read-only.
chore: Add "prepare" to scripts section of package.json #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshrn
approved these changes
Sep 16, 2021
Member
|
@yaegassy Thanks for the PR. If you want to discuss/share feedback about ansible-language-server or extension the maintainers do hang out in the IRC channel |
Member
|
@yaegassy I will need to close this PR because we removed yarn support in #22, if we need a prepare it should be for npm. Also let me first thank you for writing an extension for nvim users. While I am not one of them I do know how important it is. Feel free to add a PR to list your extension inside the readme. I hope that soon we will be able to have the testing setup and be able to check if language server changes do impact users of it (IDE extensions). |
Contributor
Author
ekmixon
pushed a commit
to ekmixon/ansible-language-server
that referenced
this pull request
Oct 15, 2021
* Fix special characters in workspace and file paths (ansible#15) * Advise yamllint installation and use (ansible#16) * Fix handling of files with CRLF line endings (ansible#20) * Mimic linter's config file search algorithm (ansible#22) Since ansible-lint is executed from the root directory of the workspace the algorithm that it uses to find configuration for a particular file is not involved. To compensate, the extension now mimics that behavior, searching the directory structure, going up from the investigated file. At the same time, it is still possible to force a particular config file through arguments provided in the extension settings. The configuration file that is actually used is now correctly identified for the purpose of marking configured finding groups as warnings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I thought it would be useful to add "prepare" so that
yarnoryarn installalone would also build.If you have not intentionally set "prepare", Please close this PR. 🙇
DEMO (mp4)
ansible-ls-add-prepare.mp4