Skip to content
This repository has been archived by the owner. It is now read-only.

simple a2ensite/a2dissite module #1240

Closed
wants to merge 4 commits into from

Conversation

@fabfurnari
Copy link

commented Nov 13, 2015

Just a copy of the very useful apache2_module module. It manages the activation and deactivation of sites using a2ensite/a2dissite commands.
It's tested and should work fine...

@fabfurnari

This comment has been minimized.

Copy link
Author

commented Nov 17, 2015

Don't know why Travis CI marks that code as incorrect

@robynbergeron

This comment has been minimized.

Copy link
Contributor

commented Nov 24, 2015

Hi @fabfurnari --

Thanks for submitting this new module to Ansible Extras! This module is now in community review, a process that is open to all Ansible users. In order for this module to be approved, it must gain the following votes, which can be contributed by anyone other than the author of the new module:

“works_for_me”: If you have tested the module thoroughly, including testing of all of the module’s options, and if the module works for you, please add “works_for_me” in the comments.

“passes_guidelines”: If you have gone through the module guidelines and the module meets all of the requirements, please add “passes_guidelines” in the comments. Guidelines are available here: http://docs.ansible.com/developing_modules.html#module-checklist

“needs_revision”: If the module fails to work for you, or if it doesn’t meet guidelines, please add “needs_revision” in the comments with details about what needs to be fixed.

When a module has both “works_for_me” and “passes_guidelines” tags, we will promote the module for inclusion in Ansible Extras. At this point, you will be expected to maintain the module by fixing bugs and evaluating pull requests in a timely manner.

More information about the review process can be seen here:
https://github.com/ansible/ansible-modules-extras/blob/devel/REVIEWERS.md

Thanks again for submitting your Ansible module!

@drzraf

This comment has been minimized.

Copy link

commented May 24, 2016

Does it support check-mode? If yes, how?

@sivel sivel referenced this pull request Aug 25, 2016
DOCUMENTATION = '''
---
module: apache2_site
version_added: 1.9

This comment has been minimized.

Copy link
@robinro

robinro Aug 25, 2016

Contributor

This would be 2.2 or 2.3.

@robinro

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2016

The module looks good to me. Things to extend:

Since a2ensite, a2enmod and a2enconf are the same (under debian/ubuntu), one could also consider to do a combined ansible module apach2_settings with type = {site, mod, conf}.
On the other hand: Suse has it's own implementation of a2enmod and doesn't have the other tools.

@ansibot

This comment has been minimized.

Copy link

commented Dec 6, 2016

This repository has been locked. All new issues and pullrequests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pullrequest to the ansible/ansible repo.

@drzraf

This comment has been minimized.

Copy link

commented Dec 6, 2016

@andig

This comment has been minimized.

Copy link

commented Feb 23, 2017

This repo should be accepting merged again? Any chance to get the site module merged?

@ansibot

This comment has been minimized.

Copy link

commented Feb 23, 2017

This repository has been locked. All new issues and pull requests should be filed in https://github.com/ansible/ansible

Please read through the repomerge page in the dev guide. The guide contains links to tools which automatically move your issue or pull request to the ansible/ansible repo.

@ansibot ansibot closed this Feb 23, 2017

@gundalow

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2017

New modules need to go into https://github.com/ansible/ansible

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants
You can’t perform that action at this time.