Conversation
the proper path for the module should be cloud/amazon/ |
Have fixed path. |
This doesn't take into account that it could be a cross account VPC peering connection. I'm not exactly sure how(lack of python skills), but you could set a flag as to whether the AWS accounts are the same for the peering VPC's and then force AWS credentials for the accepting peer. |
@viper233 that might be a good feature to add, but the module should already be useful 'as is', this ticket will closed once it is merged so I would advise opening a feature request ticket once that happens. |
Thanks for submitting this module to Ansible Extras. Apologies that it’s taken a while to get your module reviewed. To help facilitate reviews, we’ve broadened the number of people who can approve modules for inclusion into the Extras repository. The list of official reviewers can be found here: https://github.com/ansible/ansible-modules-extras/blob/devel/REVIEWERS.md Our new policy is that if a new module is reviewed and approved by at least two official module reviewers, the module will be approved for inclusion. We will be asking the community of reviewers to take a look at these modules on a regular basis. To ensure that your module has the best chance of being approved, please double-check that you adhere to the Ansible module guidelines: http://docs.ansible.com/developing_modules.html#module-checklist |
I'd love to see this merged |
👍 Just needed this module. I will hopefully get sometime this week to review and test this. |
For a current project I need to establish cross-account peering connections. I will test this module coming week('s) and let you know the findings and results. |
DOCUMENTATION = """ | ||
--- | ||
module: ec2_vpc_peer | ||
short_description: create or remove a peering connection between to ec2 VPCs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
between two ec2 VPCs
+1 i use peer connection alot in the same account, so this module will be verry usefull |
+1 I need to use this. |
+1 need this |
Tried using it, the great module. Just one small bug I found if update_routes=yes & I re-run the module (no variable changes), the output shows 'ok' but actually the route from peer vpc to local vpc in peer vpc subnet's route table is lost (it was created properly at first run). Anyway, +++1 for this great addition. |
I'm going to start using this soon (pull into my own set of modules until it is merged upstream). I'm going to try and get peering between two VPCs in separate AWS accounts working. Would this be better as 'one task' (which we will need to provide additional AWS credentials as separate varaibles) or two tasks? Two tasks I think would look like:
One task would look like:
From a playbook level I think one task seems better but not sure about the internals for AWS credentials. Haven't made EC2 modules before. Any comments on which one would most likely be accepted upstream? |
@klj613 I think that using one task will break implementations using the sts_assume_role module. |
Cross account VPC peering will not work, because the module has no peered account id parameter. |
import boto.exception | ||
except ImportError: | ||
print "failed=True msg='boto required for this module'" | ||
sys.exit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use module.fail_json(msg='boto is required for this module')
here, as in the rest of the module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because back in February this was the standard pattern used by the core modules. :-)
Have updated it to use the same pattern that they now use.
AWS cross account VPC peering module |
@manicai could you please rebase to strip out the merge commits! Thanks! |
@manicai A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer. [This message brought to you by your friendly Ansibull-bot.] |
@manicai Another friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open. If you have addressed the issues and believe it's ready for review, please comment with the text "ready_for_review". If we don't hear from you within another 14 days, we will close this pull request. [This message brought to you by your friendly Ansibull-bot.] |
@manicai A friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open pending your changes. When you do address the issues, please respond with ready_for_review in your comment, so that we can notify the maintainer. [This message brought to you by your friendly Ansibull-bot.] |
@manicai Another friendly reminder: this pull request has been marked as needing your action. If you still believe that this PR applies, and you intend to address the issues with this PR, just let us know in the PR itself and we will keep it open. If you have addressed the issues and believe it's ready for review, please comment with the text "ready_for_review". If we don't hear from you within another 14 days, we will close this pull request. [This message brought to you by your friendly Ansibull-bot.] |
Think this has been rendered redundant by #1434 so closing it. |
This module allows the creation of EC2 VPC peering connections.